Re: [PATCH 2/2] bundle: Add colons to list headings in verify

2013-03-07 Thread Junio C Hamano 
Lukas Fleischer g...@cryptocrack.de writes:

 These slightly improve the reading flow by making it obvious that a list
 follows.

 Signed-off-by: Lukas Fleischer g...@cryptocrack.de

Perhaps.

The earlier message says contains X ref(s) while the later one
says requires this/these X ref(s).  Do we want to make them
consistent, too?

 ---
  bundle.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

 diff --git a/bundle.c b/bundle.c
 index 65db53b..8cd8b4f 100644
 --- a/bundle.c
 +++ b/bundle.c
 @@ -183,8 +183,8 @@ int verify_bundle(struct bundle_header *header, int 
 verbose)
   struct ref_list *r;
  
   r = header-references;
 - printf_ln(Q_(The bundle contains %d ref,
 -  The bundle contains %d refs,
 + printf_ln(Q_(The bundle contains %d ref:,
 +  The bundle contains %d refs:,
r-nr),
 r-nr);
   list_refs(r, 0, NULL);
 @@ -192,8 +192,8 @@ int verify_bundle(struct bundle_header *header, int 
 verbose)
   if (!r-nr) {
   printf_ln(_(The bundle records a complete history.));
   } else {
 - printf_ln(Q_(The bundle requires this ref,
 -  The bundle requires these %d refs,
 + printf_ln(Q_(The bundle requires this ref:,
 +  The bundle requires these %d refs:,
r-nr),
 r-nr);
   list_refs(r, 0, NULL);
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] bundle: Add colons to list headings in verify

2013-03-06 Thread Lukas Fleischer 
These slightly improve the reading flow by making it obvious that a list
follows.

Signed-off-by: Lukas Fleischer g...@cryptocrack.de
---
 bundle.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bundle.c b/bundle.c
index 65db53b..8cd8b4f 100644
--- a/bundle.c
+++ b/bundle.c
@@ -183,8 +183,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
struct ref_list *r;
 
r = header-references;
-   printf_ln(Q_(The bundle contains %d ref,
-The bundle contains %d refs,
+   printf_ln(Q_(The bundle contains %d ref:,
+The bundle contains %d refs:,
 r-nr),
  r-nr);
list_refs(r, 0, NULL);
@@ -192,8 +192,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
if (!r-nr) {
printf_ln(_(The bundle records a complete history.));
} else {
-   printf_ln(Q_(The bundle requires this ref,
-The bundle requires these %d refs,
+   printf_ln(Q_(The bundle requires this ref:,
+The bundle requires these %d refs:,
 r-nr),
  r-nr);
list_refs(r, 0, NULL);
-- 
1.8.2.rc2.352.g908df73

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html