Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Adam Spiers
On Thu, Feb 21, 2013 at 06:13:28PM -0500, Jeff King wrote: On Thu, Feb 21, 2013 at 12:26:22PM -0800, Junio C Hamano wrote: Some people may find it convenient to append a simple patch at the bottom of a discussion e-mail separated by a scissors mark, ready to be applied with git am -c.

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... helper function to see if the user is the author ... +} Nice, I'm glad you handled this case properly. I've wondered if we should have an option to do a similar test when writing out the real message format. I.e., to put the extra From line in the body of

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Jeff King
On Fri, Feb 22, 2013 at 08:47:39AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... helper function to see if the user is the author ... +} Nice, I'm glad you handled this case properly. I've wondered if we should have an option to do a similar test when writing out

[PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Junio C Hamano
Some people may find it convenient to append a simple patch at the bottom of a discussion e-mail separated by a scissors mark, ready to be applied with git am -c. Introduce --inline-single option to format-patch to do so. A typical usage example might be to start 'F'ollow-up to a discussion,

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Jeff King
On Thu, Feb 21, 2013 at 12:26:22PM -0800, Junio C Hamano wrote: Some people may find it convenient to append a simple patch at the bottom of a discussion e-mail separated by a scissors mark, ready to be applied with git am -c. Introduce --inline-single option to format-patch to do so. A

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: @@ -421,6 +443,9 @@ void pp_user_info(const struct pretty_print_context *pp, if (pp-mailmap) map_user(pp-mailmap, mailbuf, maillen, namebuf, namelen); +if (pp-inline_single is_current_user(pp, mailbuf, maillen, namebuf, namelen)) +

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Jeff King p...@peff.net writes: @@ -421,6 +443,9 @@ void pp_user_info(const struct pretty_print_context *pp, if (pp-mailmap) map_user(pp-mailmap, mailbuf, maillen, namebuf, namelen); + if (pp-inline_single is_current_user(pp,