Re: [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
On Tue, Sep 10, 2019 at 10:28 PM Pratyush Yadav wrote:
>
> On 04/09/19 10:10PM, Bert Wesarg wrote:
> > While the commit message widget has a configurable fixed width, it
> > nevertheless allows to write commit messages which exceed this limit.
> > Though it does not show this content because there is not scrollbar for
>
> Like we discussed before, it does show the content, you just have to
> scroll by keyboard, and can't scroll by mouse. So maybe reword this?
>
> > this widget. No it is.
>
> I pulled from your GitHub since you seem to have fixed this typo there.
>
> > There seems to be a bug in at least up to Tcl/Tk 8.6.8, which does not
> > update the horizontal scrollbar if one removes the whole content at once.
> >
> > Suggested-by: Birger Skogeng Pedersen
> > Signed-off-by: Bert Wesarg
> > ---
> > git-gui.sh | 10 --
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/git-gui.sh b/git-gui.sh
> > index a491085..fa9c0d2 100755
> > --- a/git-gui.sh
> > +++ b/git-gui.sh
> > @@ -3363,14 +3363,20 @@ ttext $ui_comm -background white -foreground black \
> > -relief sunken \
> > -width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \
> > -font font_diff \
> > + -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \
> > -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set}
> > +${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \
> > + -orient horizontal \
> > + -command [list $ui_comm xview]
> > ${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \
> > + -orient vertical \
> > -command [list $ui_comm yview]
> >
> > +pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x
> > pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y
> > -pack $ui_comm -side left -fill y
> > +pack $ui_comm -side left -fill both -expand 1
>
> Dropping this change does not seem to make a difference. The commit
> message buffer expands on resize even without it. Can you please explain
> why you did this?
>
> > pack .vpane.lower.commarea.buffer.header -side top -fill x
> > -pack .vpane.lower.commarea.buffer.frame -side left -fill y
> > +pack .vpane.lower.commarea.buffer.frame -side bottom -fill both -expand 1
>
> I'm not too familiar with pack, but why did you change the side from
> left to bottom? I tested by changing it back to left and didn't notice
> any difference.
>
> > pack .vpane.lower.commarea.buffer -side left -fill y
> >
> > # -- Commit Message Buffer Context Menu
>
> Other than these couple of minor things, the patch LGTM. Thanks.
Will re-roll.
Thanks.
>
> --
> Regards,
> Pratyush Yadav
Re: [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
On 04/09/19 10:10PM, Bert Wesarg wrote:
> While the commit message widget has a configurable fixed width, it
> nevertheless allows to write commit messages which exceed this limit.
> Though it does not show this content because there is not scrollbar for
Like we discussed before, it does show the content, you just have to
scroll by keyboard, and can't scroll by mouse. So maybe reword this?
> this widget. No it is.
I pulled from your GitHub since you seem to have fixed this typo there.
> There seems to be a bug in at least up to Tcl/Tk 8.6.8, which does not
> update the horizontal scrollbar if one removes the whole content at once.
>
> Suggested-by: Birger Skogeng Pedersen
> Signed-off-by: Bert Wesarg
> ---
> git-gui.sh | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index a491085..fa9c0d2 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -3363,14 +3363,20 @@ ttext $ui_comm -background white -foreground black \
> -relief sunken \
> -width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \
> -font font_diff \
> + -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \
> -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set}
> +${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \
> + -orient horizontal \
> + -command [list $ui_comm xview]
> ${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \
> + -orient vertical \
> -command [list $ui_comm yview]
>
> +pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x
> pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y
> -pack $ui_comm -side left -fill y
> +pack $ui_comm -side left -fill both -expand 1
Dropping this change does not seem to make a difference. The commit
message buffer expands on resize even without it. Can you please explain
why you did this?
> pack .vpane.lower.commarea.buffer.header -side top -fill x
> -pack .vpane.lower.commarea.buffer.frame -side left -fill y
> +pack .vpane.lower.commarea.buffer.frame -side bottom -fill both -expand 1
I'm not too familiar with pack, but why did you change the side from
left to bottom? I tested by changing it back to left and didn't notice
any difference.
> pack .vpane.lower.commarea.buffer -side left -fill y
>
> # -- Commit Message Buffer Context Menu
Other than these couple of minor things, the patch LGTM. Thanks.
--
Regards,
Pratyush Yadav
Re: [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
On Wed, Sep 4, 2019 at 10:31 PM Eric Sunshine wrote: > > On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote: > > While the commit message widget has a configurable fixed width, it > > nevertheless allows to write commit messages which exceed this limit. > > Though it does not show this content because there is not scrollbar for > > this widget. No it is. > > "No it is" what? …there is no scrollbar for this widget. Now there is. fixed > > > Suggested-by: Birger Skogeng Pedersen > > Signed-off-by: Bert Wesarg
Re: [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote: > While the commit message widget has a configurable fixed width, it > nevertheless allows to write commit messages which exceed this limit. > Though it does not show this content because there is not scrollbar for > this widget. No it is. "No it is" what? > Suggested-by: Birger Skogeng Pedersen > Signed-off-by: Bert Wesarg
[PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
While the commit message widget has a configurable fixed width, it
nevertheless allows to write commit messages which exceed this limit.
Though it does not show this content because there is not scrollbar for
this widget. No it is.
There seems to be a bug in at least up to Tcl/Tk 8.6.8, which does not
update the horizontal scrollbar if one removes the whole content at once.
Suggested-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index a491085..fa9c0d2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3363,14 +3363,20 @@ ttext $ui_comm -background white -foreground black \
-relief sunken \
-width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \
-font font_diff \
+ -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \
-yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set}
+${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \
+ -orient horizontal \
+ -command [list $ui_comm xview]
${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \
+ -orient vertical \
-command [list $ui_comm yview]
+pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x
pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y
-pack $ui_comm -side left -fill y
+pack $ui_comm -side left -fill both -expand 1
pack .vpane.lower.commarea.buffer.header -side top -fill x
-pack .vpane.lower.commarea.buffer.frame -side left -fill y
+pack .vpane.lower.commarea.buffer.frame -side bottom -fill both -expand 1
pack .vpane.lower.commarea.buffer -side left -fill y
# -- Commit Message Buffer Context Menu
--
2.21.0.789.ga095d9d866
