Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Jeff King
On Mon, Mar 04, 2013 at 04:54:39PM -0800, Junio C Hamano wrote: This is primarily to scratch my own itch; after tagging an rc or final release, I've been doing git push k.org v1.8.2 git push k.org and the first step can easily be forgotten. With git push

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Michael Haggerty
On 03/05/2013 09:22 AM, Jeff King wrote: On Mon, Mar 04, 2013 at 04:54:39PM -0800, Junio C Hamano wrote: [...] This will find anything under refs/tags, including annotated and non-annotated tags. I wonder if it is worth making a distinction. In many workflows, unannotated tags should not be

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Junio C Hamano
Jeff King p...@peff.net writes: Should this be called --follow-tags? That makes more sense to me, as you are catching all tags. Perhaps. We are sending all zero-or-more relevant tags, so I agree that plural form is more appropriate. I have a doubt about follow, though; inertia made me use

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Jeff King
On Tue, Mar 05, 2013 at 07:58:45AM -0800, Junio C Hamano wrote: This will find anything under refs/tags, including annotated and non-annotated tags. I wonder if it is worth making a distinction. In many workflows, unannotated tags should not be leaked out to public repos. But because this

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Junio C Hamano
Jeff King p...@peff.net writes: But I wonder if fetching and pushing are different in that respect. You are (usually) fetching from a public publishing point, and it is assumed that whatever is there is useful for sharing. The only reason to limit it is to save time transferring objects the

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Jeff King
On Tue, Mar 05, 2013 at 10:15:20AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: But I wonder if fetching and pushing are different in that respect. You are (usually) fetching from a public publishing point, and it is assumed that whatever is there is useful for sharing.

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Jeff King
On Tue, Mar 05, 2013 at 12:49:57PM +0100, Michael Haggerty wrote: One obvious alternative is only to push annotated tags with this feature. That has the downside of not matching fetch's behavior, as well as withholding the feature from people whose workflow uses only unannotated tags.

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Junio C Hamano
Jeff King p...@peff.net writes: Yeah, I think that is another sensible variant. It does not really backfill in the way that Junio's patch does (e.g., if you forgot to push out v1.6 to a remote 2 weeks ago and now you are pushing out v1.7, Junio's patch will magically fill it in). I may have

Re: [PATCH 2/2] push: --follow-tag

2013-03-05 Thread Jeff King
On Tue, Mar 05, 2013 at 11:17:11AM -0800, Junio C Hamano wrote: I may have tentatively tagged the tip of 'master' as v1.8.2 in my private repository, started the integration testing, but may not be confident enough to push out the branch nor the tag yet. I may have an experimental topic that

[PATCH 2/2] push: --follow-tag

2013-03-04 Thread Junio C Hamano
The new option --follow-tag tells git push to push tags that are missing from the other side and that can be reached by the history that is otherwise pushed out. For example, if you are using the simple, current, or upstream push, you would ordinarily push the history leading to the commit at