Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

2013-04-29 Thread Junio C Hamano
John Keeping writes: > This is identical to the interdiff of what I posted at the same time, so > it obviously looks good to me. Thanks. I've replaced the old tip with your version. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kern

Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

2013-04-29 Thread John Keeping
On Mon, Apr 29, 2013 at 11:17:00AM -0700, Junio C Hamano wrote: > Thomas Rast writes: > > > John Keeping writes: > >> diff --git a/t/test-lib.sh b/t/test-lib.sh > >> index ca6bdef..70ad085 100644 > >> --- a/t/test-lib.sh > >> +++ b/t/test-lib.sh > >> @@ -54,8 +54,8 @@ done,*) > >># do not re

Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

2013-04-29 Thread Junio C Hamano
Thomas Rast writes: > John Keeping writes: >> diff --git a/t/test-lib.sh b/t/test-lib.sh >> index ca6bdef..70ad085 100644 >> --- a/t/test-lib.sh >> +++ b/t/test-lib.sh >> @@ -54,8 +54,8 @@ done,*) >> # do not redirect again >> ;; >> *' --tee '*|*' --va'*) >> -mkdir -p test-results

Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

2013-04-29 Thread Thomas Rast
John Keeping writes: > diff --git a/t/test-lib.sh b/t/test-lib.sh > index ca6bdef..70ad085 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -54,8 +54,8 @@ done,*) > # do not redirect again > ;; > *' --tee '*|*' --va'*) > - mkdir -p test-results > - BASE=test-results/$(b

[PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

2013-04-26 Thread John Keeping
Most test results go in $TEST_OUTPUT_DIRECTORY, but the output files for tests run with --tee or --valgrind just use bare "test-results". Changes these so that they do respect $TEST_OUTPUT_DIRECTORY. As a result of this, the valgrind/analyze.sh script may no longer inspect the correct files so it