Re: [PATCH 2/2] trace: improve performance while category is disabled

> Spotted yet another. This function in a header file, that is included by many source files, must be made "static inline" (which I already did as without the fix I couldn't get 'pu' to compile). Thanks, missed that, seems my compiler inlined all calls and I didn't notice the problem. On 27

Re: [PATCH 2/2] trace: improve performance while category is disabled

Junio C Hamano writes: > Just in case others notice style and whitespace issues, I've applied > the following to fix them, so there is no need to reroll only to fix > these. > ... > -inline int trace_pass_fl(struct trace_key *key) { > +inline int trace_pass_fl(struct trace_key

Re: [PATCH 2/2] trace: improve performance while category is disabled

Junio C Hamano writes: > gennady.kup...@gmail.com writes: > >> From: Gennady Kupava >> >> - Do the check if the trace key is enabled sooner in call chain. >> - Move just enough code from trace.c into trace.h header so all code >> necessary to

Re: [PATCH 2/2] trace: improve performance while category is disabled

gennady.kup...@gmail.com writes: > From: Gennady Kupava > > - Do the check if the trace key is enabled sooner in call chain. > - Move just enough code from trace.c into trace.h header so all code > necessary to determine that trace is disabled could be inlined to >

[PATCH 2/2] trace: improve performance while category is disabled

From: Gennady Kupava - Do the check if the trace key is enabled sooner in call chain. - Move just enough code from trace.c into trace.h header so all code necessary to determine that trace is disabled could be inlined to calling functions. Signed-off-by: Gennady