Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

2013-11-03 Thread Johannes Sixt
Am 02.11.2013 21:47, schrieb Sebastian Schuberth: > So maybe it's a good point now to also change the MINGW prerequisite > name to MSYS as part of your patch, and then name the functions more > appropriately? It's too late. The series is already in master, and I see no point in a follow-up patch o

Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

2013-11-02 Thread Sebastian Schuberth
On Sat, Nov 2, 2013 at 9:40 PM, Johannes Sixt wrote: >>> In a number of tests, output that was produced by a shell script is >>> compared to expected output using test_cmp. Unfortunately, the MSYS >>> bash-- >>> when invoked via git, such as in hooks--converts LF to CRLF on output >>> (as produce

Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

2013-11-02 Thread Johannes Sixt
Am 02.11.2013 21:33, schrieb Sebastian Schuberth: > On 26.10.2013 21:17, Johannes Sixt wrote: > >> In a number of tests, output that was produced by a shell script is >> compared to expected output using test_cmp. Unfortunately, the MSYS >> bash-- >> when invoked via git, such as in hooks--convert

Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

2013-11-02 Thread Sebastian Schuberth
On 26.10.2013 21:17, Johannes Sixt wrote: In a number of tests, output that was produced by a shell script is compared to expected output using test_cmp. Unfortunately, the MSYS bash-- when invoked via git, such as in hooks--converts LF to CRLF on output (as produced by echo and printf), which l

[PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions

2013-10-26 Thread Johannes Sixt
In a number of tests, output that was produced by a shell script is compared to expected output using test_cmp. Unfortunately, the MSYS bash-- when invoked via git, such as in hooks--converts LF to CRLF on output (as produced by echo and printf), which leads to many false positives. Implements a d