Re: [PATCH 2/3] i18n: archive: mark errors for translation
A Ter, 09-08-2016 às 12:35 -0700, Junio C Hamano escreveu: > Hmm, this function is called by write_archive(), which can be called > by the upload-archive process running on the remote end, whose > locale certainly is different from that of your local environment. > > If I do not read English and got one of these messages from the > remote end, I can copy that into a search engine to read more about > the error, but if I got it translated into, say, Portuguese, I'd > have a (slightly) harder time dealing with the error, I would think. > > Having said that, I expect that sites that expect internatinal > audience to come would run these services in C locale, and other > sites that target audiences in a single locale would choose to use > their favourite single locale, so probably we do not have to worry > about it. I don't know what is the best. I trust you to decide. I'm happy with whatever you decide. When I marked those string I did not noticed what you did, just spot the string and marked them. So I submitted this without taking that into consideration. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] i18n: archive: mark errors for translation
Vasco Almeida writes: > Signed-off-by: Vasco Almeida > --- > archive.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/archive.c b/archive.c > index 42df974..dde1ab4 100644 > --- a/archive.c > +++ b/archive.c > @@ -458,11 +458,11 @@ static int parse_archive_args(int argc, const char > **argv, > argc = parse_options(argc, argv, NULL, opts, archive_usage, 0); > > if (remote) > - die("Unexpected option --remote"); > + die(_("Unexpected option --remote")); > if (exec) > - die("Option --exec can only be used together with --remote"); > + die(_("Option --exec can only be used together with --remote")); > if (output) > - die("Unexpected option --output"); > + die(_("Unexpected option --output")); > ... > - die("Unknown archive format '%s'", format); > + die(_("Unknown archive format '%s'"), format); > ... > - die("Argument not supported for format '%s': -%d", > + die(_("Argument not supported for format '%s': -%d"), > format, compression_level); Hmm, this function is called by write_archive(), which can be called by the upload-archive process running on the remote end, whose locale certainly is different from that of your local environment. If I do not read English and got one of these messages from the remote end, I can copy that into a search engine to read more about the error, but if I got it translated into, say, Portuguese, I'd have a (slightly) harder time dealing with the error, I would think. Having said that, I expect that sites that expect internatinal audience to come would run these services in C locale, and other sites that target audiences in a single locale would choose to use their favourite single locale, so probably we do not have to worry about it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] i18n: archive: mark errors for translation
Signed-off-by: Vasco Almeida --- archive.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/archive.c b/archive.c index 42df974..dde1ab4 100644 --- a/archive.c +++ b/archive.c @@ -458,11 +458,11 @@ static int parse_archive_args(int argc, const char **argv, argc = parse_options(argc, argv, NULL, opts, archive_usage, 0); if (remote) - die("Unexpected option --remote"); + die(_("Unexpected option --remote")); if (exec) - die("Option --exec can only be used together with --remote"); + die(_("Option --exec can only be used together with --remote")); if (output) - die("Unexpected option --output"); + die(_("Unexpected option --output")); if (!base) base = ""; @@ -484,14 +484,14 @@ static int parse_archive_args(int argc, const char **argv, usage_with_options(archive_usage, opts); *ar = lookup_archiver(format); if (!*ar || (is_remote && !((*ar)->flags & ARCHIVER_REMOTE))) - die("Unknown archive format '%s'", format); + die(_("Unknown archive format '%s'"), format); args->compression_level = Z_DEFAULT_COMPRESSION; if (compression_level != -1) { if ((*ar)->flags & ARCHIVER_WANT_COMPRESSION_LEVELS) args->compression_level = compression_level; else { - die("Argument not supported for format '%s': -%d", + die(_("Argument not supported for format '%s': -%d"), format, compression_level); } } -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html