[PATCH 2/3] sha1: clean pointer arithmetic

2012-09-12 Thread Yann Droneaud
One memcpy() argument is computed from a pointer added to an integer: eg. int + pointer. It's unusal. Let's write it in the correct order: pointer + offset. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- block-sha1/sha1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] sha1: clean pointer arithmetic

2012-09-12 Thread Junio C Hamano
Yann Droneaud ydrone...@opteya.com writes: One memcpy() argument is computed from a pointer added to an integer: eg. int + pointer. It's unusal. Let's write it in the correct order: pointer + offset. Meh. Both are correct. Aren't ctx-w[lenW] and lenW[ctx-w] both correct, even?