Re: [PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-09 Thread Jacob Keller
On Fri, Sep 9, 2016 at 4:22 AM, Jeff King wrote: > If you're curious what the fix looks like, it's in: > > https://github.com/peff/git jk/config-repo-setup > > The actual fix is in the final patch, but it needed a lot of preparatory > work to avoid breaking various programs that made bad assumpt

Re: [PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-09 Thread Jeff King
On Fri, Sep 09, 2016 at 05:32:21PM +0700, Duy Nguyen wrote: > On Fri, Sep 9, 2016 at 3:02 AM, Jeff King wrote: > > On Thu, Sep 08, 2016 at 08:47:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > >> git-init somehow reads '.git/config' at current directory and sets > >> log_all_ref_updates based on th

Re: [PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-09 Thread Duy Nguyen
On Fri, Sep 9, 2016 at 3:02 AM, Jeff King wrote: > On Thu, Sep 08, 2016 at 08:47:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> git-init somehow reads '.git/config' at current directory and sets >> log_all_ref_updates based on this file. Because log_all_ref_updates is >> not unspecified (-1) any mor

Re: [PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 08:47:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > git-init somehow reads '.git/config' at current directory and sets > log_all_ref_updates based on this file. Because log_all_ref_updates is > not unspecified (-1) any more. It will not be written to the new repo's > config fil

Re: [PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-08 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > git-init somehow reads '.git/config' at current directory and sets > log_all_ref_updates based on this file. Because log_all_ref_updates is > not unspecified (-1) any more. It will not be written to the new repo's > config file (see create_default_files() function)

[PATCH 2/3] t0001: work around the bug that reads config file before repo setup

2016-09-08 Thread Nguyễn Thái Ngọc Duy
git-init somehow reads '.git/config' at current directory and sets log_all_ref_updates based on this file. Because log_all_ref_updates is not unspecified (-1) any more. It will not be written to the new repo's config file (see create_default_files() function). This will affect our tests in the nex