Re: [PATCH 2/4] cat-file: introduce the --filters option

Hi Torsten, On Mon, 22 Aug 2016, Torsten Bögershausen wrote: > On 19.08.16 17:00, Johannes Schindelin wrote: > > > > On Fri, 19 Aug 2016, Torsten Bögershausen wrote: > > > >> On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: > >> > >>> +--filters:: > >>> + Show the content as

Re: [PATCH 2/4] cat-file: introduce the --filters option

On 19.08.16 17:00, Johannes Schindelin wrote: > Hi Torsten, > > On Fri, 19 Aug 2016, Torsten Bögershausen wrote: > >> On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: >> >>> +--filters:: >>> + Show the content as transformed by the filters configured in >> Minor comment: >>

Re: [PATCH 2/4] cat-file: introduce the --filters option

Johannes Schindelin writes: >> Does it make sense to be more specific here: >> The order of conversion is >> - ident >> - CRLF >> - smudge > > I do not think it makes sense to complexify the documentation in that > manner. Right. -- To unsubscribe from this list:

Re: [PATCH 2/4] cat-file: introduce the --filters option

Johannes Schindelin writes: > Actually, I find it much harder to debug these "the output must match > these precise bytes, else we fail" type of test cases. Instead, I describe > in a natural way what is expected: > > ! has_cr actual > > Now, when the test

Re: [PATCH 2/4] cat-file: introduce the --filters option

Hi Torsten, On Fri, 19 Aug 2016, Torsten Bögershausen wrote: > On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: > > > +--filters:: > > + Show the content as transformed by the filters configured in > > Minor comment: > s/transformed/converted/ ? Sure. > Does it make

Re: [PATCH 2/4] cat-file: introduce the --filters option

Hi Junio, On Thu, 18 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > As suggested by its name, the --filters option applies the filters > > that are currently configured for the specified path. > > > > [...] > > I think you can lose the last

Re: [PATCH 2/4] cat-file: introduce the --filters option

Hi Torsten, On Thu, 18 Aug 2016, Torsten Bögershausen wrote: > On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: > > As suggested by its name, the --filters option applies the filters > > [] > > diff --git a/t/t8010-cat-file-filters.sh b/t/t8010-cat-file-filters.sh > > Does

Re: [PATCH 2/4] cat-file: introduce the --filters option

[] On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: > diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt > index 071029b..7d48735 100644 > --- a/Documentation/git-cat-file.txt > +++ b/Documentation/git-cat-file.txt > @@ -9,15 +9,15 @@ git-cat-file -

Re: [PATCH 2/4] cat-file: introduce the --filters option

On Thu, Aug 18, 2016 at 02:46:17PM +0200, Johannes Schindelin wrote: > As suggested by its name, the --filters option applies the filters [] > diff --git a/t/t8010-cat-file-filters.sh b/t/t8010-cat-file-filters.sh Does it make sense to integrate tests into t1006-cat-file ? > new file mode 100755

Re: [PATCH 2/4] cat-file: introduce the --filters option

Johannes Schindelin writes: > As suggested by its name, the --filters option applies the filters > that are currently configured for the specified path. > > This feature comes in handy when a 3rd-party tool wants to work with > the contents of files from past

[PATCH 2/4] cat-file: introduce the --filters option

As suggested by its name, the --filters option applies the filters that are currently configured for the specified path. This feature comes in handy when a 3rd-party tool wants to work with the contents of files from past revisions as if they had been checked out, but without detouring via