[PATCH 2/4] commit: Fix a memory leak in determine_author_info

2013-07-14 Thread Stefan Beller
The date variable is assigned new memory via xmemdupz and 2 lines later
it is assigned new memory again via xmalloc, but the first assignment
is never freed nor used.

Signed-off-by: Stefan Beller stefanbel...@googlemail.com
---
 builtin/commit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 790e5ab..00da83c 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -528,19 +528,18 @@ static void determine_author_info(struct strbuf 
*author_ident)
 
if (lb == a + strlen(\nauthor ))
/* \nauthor f...@example.com */
name = xcalloc(1, 1);
else
name = xmemdupz(a + strlen(\nauthor ),
(lb - strlen( ) -
 (a + strlen(\nauthor ;
email = xmemdupz(lb + strlen(), rb - (lb + strlen()));
-   date = xmemdupz(rb + strlen( ), eol - (rb + strlen( )));
len = eol - (rb + strlen( ));
date = xmalloc(len + 2);
*date = '@';
memcpy(date + 1, rb + strlen( ), len);
date[len + 1] = '\0';
}
 
if (force_author) {
const char *lb = strstr(force_author,  );
-- 
1.8.3.2.806.gdee5b9b

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/4] commit: Fix a memory leak in determine_author_info

2013-07-14 Thread Jonathan Nieder
Stefan Beller wrote:

 Signed-off-by: Stefan Beller stefanbel...@googlemail.com

Thanks.  That was quick. :)

Reviewed-by: Jonathan Nieder jrnie...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html