Re: [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`

2014-07-19 Thread John Keeping 
On Sat, Jul 19, 2014 at 01:37:26PM +0200, Johannes Sixt wrote:
> Am 19.07.2014 11:45, schrieb John Keeping:
> > Since the argument to `--recurse-submodules` is mandatory, it does not
> > need to be stuck to the option with `=`.
> > 
> > Signed-off-by: John Keeping 
> > ---
> >  contrib/completion/git-completion.bash | 4 
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/contrib/completion/git-completion.bash 
> > b/contrib/completion/git-completion.bash
> > index d0b2895..06211a6 100644
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
> >  _git_push ()
> >  {
> > case "$prev" in
> > +   --recurse_submodules)
> 
> This would need a dash, not an underscore.

Thanks.  I'll wait to see if there are any more comments before
re-rolling.

> > +   __gitcomp "$__git_push_recurse_submodules"
> > +   return
> > +   ;;
> > --repo)
> > __gitcomp_nl "$(__git_remotes)"
> > return
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`

2014-07-19 Thread Johannes Sixt 
Am 19.07.2014 11:45, schrieb John Keeping:
> Since the argument to `--recurse-submodules` is mandatory, it does not
> need to be stuck to the option with `=`.
> 
> Signed-off-by: John Keeping 
> ---
>  contrib/completion/git-completion.bash | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/contrib/completion/git-completion.bash 
> b/contrib/completion/git-completion.bash
> index d0b2895..06211a6 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
>  _git_push ()
>  {
>   case "$prev" in
> + --recurse_submodules)

This would need a dash, not an underscore.

> + __gitcomp "$__git_push_recurse_submodules"
> + return
> + ;;
>   --repo)
>   __gitcomp_nl "$(__git_remotes)"
>   return
> 

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`

2014-07-19 Thread John Keeping 
Since the argument to `--recurse-submodules` is mandatory, it does not
need to be stuck to the option with `=`.

Signed-off-by: John Keeping 
---
 contrib/completion/git-completion.bash | 4 
 1 file changed, 4 insertions(+)

diff --git a/contrib/completion/git-completion.bash 
b/contrib/completion/git-completion.bash
index d0b2895..06211a6 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
 _git_push ()
 {
case "$prev" in
+   --recurse_submodules)
+   __gitcomp "$__git_push_recurse_submodules"
+   return
+   ;;
--repo)
__gitcomp_nl "$(__git_remotes)"
return
-- 
2.0.1.472.g6f92e5f.dirty

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html