Re: [PATCH 2/4] pathspec: do exact comparison on the leading non-wildcard part

On Tue, Nov 20, 2012 at 3:54 AM, Junio C Hamano wrote: > How would we protect this optimization from future breakages? > > Once we start using FNM_PERIOD, this becomes unsafe, as the simple > part in "foo/bar*baz" would be "foo/bar" with remainder "*baz". > > The pattern "foo/bar*baz" should match

Re: [PATCH 2/4] pathspec: do exact comparison on the leading non-wildcard part

Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > dir.c | 18 +- > dir.h | 8 > tree-walk.c | 6 -- > 3 files changed, 29 insertions(+), 3 deletions(-) > > diff --git a/dir.c b/dir.c > index c391d46..e4e6ca1 100644 > --- a/dir

[PATCH 2/4] pathspec: do exact comparison on the leading non-wildcard part

Signed-off-by: Nguyễn Thái Ngọc Duy --- dir.c | 18 +- dir.h | 8 tree-walk.c | 6 -- 3 files changed, 29 insertions(+), 3 deletions(-) diff --git a/dir.c b/dir.c index c391d46..e4e6ca1 100644 --- a/dir.c +++ b/dir.c @@ -34,6 +34,21 @@ int fnmatch_icas