Re: [PATCH 2/4] remote-helpers: rename tests
On Wed, May 29, 2013 at 1:44 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> > I do not see how it makes sense to copy how they deviate from us > back to our codebase, especially if we plan to eventually move some > of these tests out of contrib/ area, but even without such a plan in > the future. They deviate from us, we deviate from them, whatever. We are a single project, what more than one project does is more standard. >>> >>> We are a single project, so it is better to consistently follow the >>> local convention established here. >>> >>> If your proposal were to >>> >>> - Convert t/*.sh to end with .t intead, to change the project >>>convention, and >>> >>> - Make contrib/ things also conform to that new convention. >>> >>> it may make some sense to discuss the pros and cons of such a move, >>> but changing only contrib/ has no effect other than making it even >>> less consistent with the rest of the project. >> >> It's already inconsistent with the rest of the project, as they are >> not named t-foo.sh. > > Correct; that is why I said "even less consistent". > >> If you want I can give it a try at renaming all the tests in the whole >> project to *.t, but I don't think you are truly interested in finding >> a better extension for our tests. > > Again, correct. I do not think it is worth the trouble to renaming > them to *.t at this moment. > > Having said that, I suspect that in the very longer term it might > turn out to be a good thing to do (if we want to make our test suite > runnable under other people's tools that expect .t suffix, for > example). But I do not think that is the topic of this patch under > discussion. That's right. I just think if we didn't have the burden of so many existing tests, and had the chance to pick the test extension from scratch, it should be .t. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] remote-helpers: rename tests
Felipe Contreras writes: > On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> I do not see how it makes sense to copy how they deviate from us back to our codebase, especially if we plan to eventually move some of these tests out of contrib/ area, but even without such a plan in the future. >>> >>> They deviate from us, we deviate from them, whatever. We are a single >>> project, >>> what more than one project does is more standard. >> >> We are a single project, so it is better to consistently follow the >> local convention established here. >> >> If your proposal were to >> >> - Convert t/*.sh to end with .t intead, to change the project >>convention, and >> >> - Make contrib/ things also conform to that new convention. >> >> it may make some sense to discuss the pros and cons of such a move, >> but changing only contrib/ has no effect other than making it even >> less consistent with the rest of the project. > > It's already inconsistent with the rest of the project, as they are > not named t-foo.sh. Correct; that is why I said "even less consistent". > If you want I can give it a try at renaming all the tests in the whole > project to *.t, but I don't think you are truly interested in finding > a better extension for our tests. Again, correct. I do not think it is worth the trouble to renaming them to *.t at this moment. Having said that, I suspect that in the very longer term it might turn out to be a good thing to do (if we want to make our test suite runnable under other people's tools that expect .t suffix, for example). But I do not think that is the topic of this patch under discussion. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] remote-helpers: rename tests
On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >>> I do not see how it makes sense to copy how they deviate from us >>> back to our codebase, especially if we plan to eventually move some >>> of these tests out of contrib/ area, but even without such a plan in >>> the future. >> >> They deviate from us, we deviate from them, whatever. We are a single >> project, >> what more than one project does is more standard. > > We are a single project, so it is better to consistently follow the > local convention established here. > > If your proposal were to > > - Convert t/*.sh to end with .t intead, to change the project >convention, and > > - Make contrib/ things also conform to that new convention. > > it may make some sense to discuss the pros and cons of such a move, > but changing only contrib/ has no effect other than making it even > less consistent with the rest of the project. It's already inconsistent with the rest of the project, as they are not named t-foo.sh. If you want I can give it a try at renaming all the tests in the whole project to *.t, but I don't think you are truly interested in finding a better extension for our tests. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] remote-helpers: rename tests
Felipe Contreras writes: >> I do not see how it makes sense to copy how they deviate from us >> back to our codebase, especially if we plan to eventually move some >> of these tests out of contrib/ area, but even without such a plan in >> the future. > > They deviate from us, we deviate from them, whatever. We are a single project, > what more than one project does is more standard. We are a single project, so it is better to consistently follow the local convention established here. If your proposal were to - Convert t/*.sh to end with .t intead, to change the project convention, and - Make contrib/ things also conform to that new convention. it may make some sense to discuss the pros and cons of such a move, but changing only contrib/ has no effect other than making it even less consistent with the rest of the project. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] remote-helpers: rename tests
Junio C Hamano wrote: > Felipe Contreras writes: > > > The .t extension is more standard for sharness tests. > > > > Signed-off-by: Felipe Contreras > > --- > > Is that "sharness" test the sh script testsuite forked from our > testsuite? > > I do not see how it makes sense to copy how they deviate from us > back to our codebase, especially if we plan to eventually move some > of these tests out of contrib/ area, but even without such a plan in > the future. They deviate from us, we deviate from them, whatever. We are a single project, what more than one project does is more standard. % man prove --ext Set the extension for tests (default '.t') -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] remote-helpers: rename tests
Felipe Contreras writes:
> The .t extension is more standard for sharness tests.
>
> Signed-off-by: Felipe Contreras
> ---
Is that "sharness" test the sh script testsuite forked from our
testsuite?
I do not see how it makes sense to copy how they deviate from us
back to our codebase, especially if we plan to eventually move some
of these tests out of contrib/ area, but even without such a plan in
the future.
> contrib/remote-helpers/Makefile| 2 +-
> contrib/remote-helpers/{test-bzr.sh => test-bzr.t} | 0
> contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} | 0
> contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} | 0
> contrib/remote-helpers/{test-hg.sh => test-hg.t} | 0
> 5 files changed, 1 insertion(+), 1 deletion(-)
> rename contrib/remote-helpers/{test-bzr.sh => test-bzr.t} (100%)
> rename contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} (100%)
> rename contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} (100%)
> rename contrib/remote-helpers/{test-hg.sh => test-hg.t} (100%)
>
> diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile
> index d9b3515..2c91ec6 100644
> --- a/contrib/remote-helpers/Makefile
> +++ b/contrib/remote-helpers/Makefile
> @@ -1,4 +1,4 @@
> -TESTS := $(wildcard test*.sh)
> +TESTS := $(wildcard test-*.t)
> SCRIPTS := $(wildcard git-remote-*.py)
>
> export T := $(addprefix $(CURDIR)/,$(TESTS))
> diff --git a/contrib/remote-helpers/test-bzr.sh
> b/contrib/remote-helpers/test-bzr.t
> similarity index 100%
> rename from contrib/remote-helpers/test-bzr.sh
> rename to contrib/remote-helpers/test-bzr.t
> diff --git a/contrib/remote-helpers/test-hg-bidi.sh
> b/contrib/remote-helpers/test-hg-bidi.t
> similarity index 100%
> rename from contrib/remote-helpers/test-hg-bidi.sh
> rename to contrib/remote-helpers/test-hg-bidi.t
> diff --git a/contrib/remote-helpers/test-hg-hg-git.sh
> b/contrib/remote-helpers/test-hg-hg-git.t
> similarity index 100%
> rename from contrib/remote-helpers/test-hg-hg-git.sh
> rename to contrib/remote-helpers/test-hg-hg-git.t
> diff --git a/contrib/remote-helpers/test-hg.sh
> b/contrib/remote-helpers/test-hg.t
> similarity index 100%
> rename from contrib/remote-helpers/test-hg.sh
> rename to contrib/remote-helpers/test-hg.t
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/4] remote-helpers: rename tests
The .t extension is more standard for sharness tests.
Signed-off-by: Felipe Contreras
---
contrib/remote-helpers/Makefile| 2 +-
contrib/remote-helpers/{test-bzr.sh => test-bzr.t} | 0
contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} | 0
contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} | 0
contrib/remote-helpers/{test-hg.sh => test-hg.t} | 0
5 files changed, 1 insertion(+), 1 deletion(-)
rename contrib/remote-helpers/{test-bzr.sh => test-bzr.t} (100%)
rename contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} (100%)
rename contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} (100%)
rename contrib/remote-helpers/{test-hg.sh => test-hg.t} (100%)
diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile
index d9b3515..2c91ec6 100644
--- a/contrib/remote-helpers/Makefile
+++ b/contrib/remote-helpers/Makefile
@@ -1,4 +1,4 @@
-TESTS := $(wildcard test*.sh)
+TESTS := $(wildcard test-*.t)
SCRIPTS := $(wildcard git-remote-*.py)
export T := $(addprefix $(CURDIR)/,$(TESTS))
diff --git a/contrib/remote-helpers/test-bzr.sh
b/contrib/remote-helpers/test-bzr.t
similarity index 100%
rename from contrib/remote-helpers/test-bzr.sh
rename to contrib/remote-helpers/test-bzr.t
diff --git a/contrib/remote-helpers/test-hg-bidi.sh
b/contrib/remote-helpers/test-hg-bidi.t
similarity index 100%
rename from contrib/remote-helpers/test-hg-bidi.sh
rename to contrib/remote-helpers/test-hg-bidi.t
diff --git a/contrib/remote-helpers/test-hg-hg-git.sh
b/contrib/remote-helpers/test-hg-hg-git.t
similarity index 100%
rename from contrib/remote-helpers/test-hg-hg-git.sh
rename to contrib/remote-helpers/test-hg-hg-git.t
diff --git a/contrib/remote-helpers/test-hg.sh
b/contrib/remote-helpers/test-hg.t
similarity index 100%
rename from contrib/remote-helpers/test-hg.sh
rename to contrib/remote-helpers/test-hg.t
--
1.8.3.rc3.312.g47657de
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
