Re: [PATCH 2/6] Disable t0110's high-bit test on Windows
Karsten Blees writes: > Am 17.07.2014 17:37, schrieb Stepan Kasal: >> From: Johannes Schindelin >> >> The bash Git for Windows uses (i.e. the MSys bash) cannot pass >> command-line arguments with high bits set verbatim to non-MSys programs, >> but instead converts those characters with high bits set to their hex >> representation. >> > > The description is not entirely correct...the Unicode-enabled MSYS.dll > expects the command line to be UTF-8. Only *invalid* UTF-8 is converted > to hex code for convenience. So its not the high bits that cause trouble, > but specifying 0x80 without proper UTF-8 lead byte. > > I believe the last line of the test may actually work: > > test "$(test-urlmatch-normalization -p "$(cat "$tu-11")")" = > "x://q/%C2%80%DF%BF%E0%A0%80%EF%BF%BD%F0%90%80%80%F0%AF%BF%BD" > > -- Can somebody send a tested replacement then? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] Disable t0110's high-bit test on Windows
Am 17.07.2014 17:37, schrieb Stepan Kasal: > From: Johannes Schindelin > > The bash Git for Windows uses (i.e. the MSys bash) cannot pass > command-line arguments with high bits set verbatim to non-MSys programs, > but instead converts those characters with high bits set to their hex > representation. > The description is not entirely correct...the Unicode-enabled MSYS.dll expects the command line to be UTF-8. Only *invalid* UTF-8 is converted to hex code for convenience. So its not the high bits that cause trouble, but specifying 0x80 without proper UTF-8 lead byte. I believe the last line of the test may actually work: test "$(test-urlmatch-normalization -p "$(cat "$tu-11")")" = "x://q/%C2%80%DF%BF%E0%A0%80%EF%BF%BD%F0%90%80%80%F0%AF%BF%BD" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/6] Disable t0110's high-bit test on Windows
From: Johannes Schindelin The bash Git for Windows uses (i.e. the MSys bash) cannot pass command-line arguments with high bits set verbatim to non-MSys programs, but instead converts those characters with high bits set to their hex representation. For example, when running strings "$(echo -e '\x80')" (where strings.exe is a MinGW program, not an MSys one) it will complain about not finding the file called "80". Signed-off-by: Johannes Schindelin Signed-off-by: Stepan Kasal --- t/t0110-urlmatch-normalization.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0110-urlmatch-normalization.sh b/t/t0110-urlmatch-normalization.sh index 8d6096d..bcbb825 100755 --- a/t/t0110-urlmatch-normalization.sh +++ b/t/t0110-urlmatch-normalization.sh @@ -117,7 +117,7 @@ test_expect_success 'url general escapes' ' test "$(test-urlmatch-normalization -p "X://W?'\!'")" = "x://w/?'\!'" ' -test_expect_success 'url high-bit escapes' ' +test_expect_success !MINGW 'url high-bit escapes' ' test "$(test-urlmatch-normalization -p "$(cat "$tu-1")")" = "x://q/%01%02%03%04%05%06%07%08%0E%0F%10%11%12" && test "$(test-urlmatch-normalization -p "$(cat "$tu-2")")" = "x://q/%13%14%15%16%17%18%19%1B%1C%1D%1E%1F%7F" && test "$(test-urlmatch-normalization -p "$(cat "$tu-3")")" = "x://q/%80%81%82%83%84%85%86%87%88%89%8A%8B%8C%8D%8E%8F" && -- 2.0.0.9635.g0be03cb -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
