Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-13 Thread Junio C Hamano
Marc Branchaud marcn...@xiplink.com writes: Is it even a _side effect_? Isn't this one of the primary points of the series? I do not think this patch makes sense if we did not want that change to happen. Or am I missing something? No, you're not -- I agree that this change in behaviour

[PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-11 Thread marcnarc
From: Marc Branchaud marcn...@xiplink.com The code now has a default_remote_name and an effective_remote_name: - default_remote_name is set by remote.default in the config, or is origin if remote.default doesn't exist (origin was the fallback value before this change). -

Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-11 Thread Junio C Hamano
marcn...@xiplink.com writes: From: Marc Branchaud marcn...@xiplink.com The code now has a default_remote_name and an effective_remote_name: - default_remote_name is set by remote.default in the config, or is origin if remote.default doesn't exist (origin was the fallback value before

Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-11 Thread Marc Branchaud
On 12-07-11 02:21 PM, Junio C Hamano wrote: marcn...@xiplink.com writes: From: Marc Branchaud marcn...@xiplink.com The code now has a default_remote_name and an effective_remote_name: - default_remote_name is set by remote.default in the config, or is origin if remote.default doesn't

Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-11 Thread Junio C Hamano
Marc Branchaud marcn...@xiplink.com writes: On 12-07-11 02:21 PM, Junio C Hamano wrote: marcn...@xiplink.com writes: From: Marc Branchaud marcn...@xiplink.com The code now has a default_remote_name and an effective_remote_name: - default_remote_name is set by remote.default in the

Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-06 Thread Junio C Hamano
Marc Branchaud marcn...@xiplink.com writes: On 12-07-05 06:50 PM, Junio C Hamano wrote: - effective_remote_name is the name of the remote tracked by the current branch, or is default_remote_name if the current branch doesn't have a remote. The explanation of the latter belongs to

Re: [PATCH 2/6] Teach remote.c about the remote.default configuration setting.

2012-07-06 Thread Marc Branchaud
On 12-07-06 03:31 PM, Junio C Hamano wrote: Marc Branchaud marcn...@xiplink.com writes: On 12-07-05 06:50 PM, Junio C Hamano wrote: - effective_remote_name is the name of the remote tracked by the current branch, or is default_remote_name if the current branch doesn't have a remote.