Re: [PATCH 3/3] diff: remove dead code

2016-09-08 Thread Junio C Hamano
Stefan Beller writes: > When `len < 1`, len has to be 0 or negative, emit_line will then remove the > first character and by then `len` would be negative. As this doesn't > happen, it is safe to assume it is dead code. > > This continues to simplify the code, which was started in b8d9c1a66b > (20

[PATCH 3/3] diff: remove dead code

2016-09-07 Thread Stefan Beller
When `len < 1`, len has to be 0 or negative, emit_line will then remove the first character and by then `len` would be negative. As this doesn't happen, it is safe to assume it is dead code. This continues to simplify the code, which was started in b8d9c1a66b (2009-09-03, diff.c: the builtin_diff