[PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Ramkumar Ramachandra
Clarify that -- is meant to disambiguate paths from the other options. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- Documentation/git-diff.txt | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/git-diff.txt

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: -'git diff' [options] [--] [path...]:: +'git diff' [options] [[--] [path...]]:: You can say git diff A B -- without any path git diff A B pathspec without any double-dashes git diff -- pathspec and all three of them are expressed by

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Ramkumar Ramachandra
Junio C Hamano wrote: While the update might be logically more correct, it looks to me that the only end-user visibile effect of it is to make the end result harder to read. Hm, I thought it improves readability. I'm trying to say that -- is used to separate [path...] from [everything else].

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: -'git diff' [options] [--] [path...]:: +'git diff' [options] [[--] [path...]]:: While the update might be logically more correct, it looks to me that the only end-user visibile effect of it is to make the end result

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Ramkumar Ramachandra
Junio C Hamano wrote: The same logic would apply to this semi-nonsense rewrite, no? git diff [[options] [--]] [path...] Everything else comes before -- (if exists) that separates it from the list of pathspecs. Yeah, except it's sometimes [[options] [revision range] [--]]

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: Hm, I thought it improves readability. I'm trying to say that -- is used to separate [path...] from [everything else]. I agree with the goal, but I don't think this change achieves it. Maybe adding gitcli(7) to the SEE ALSO section would work? Jonathan -- To

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: The same logic would apply to this semi-nonsense rewrite, no? git diff [[options] [--]] [path...] Everything else comes before -- (if exists) that separates it from the list of pathspecs. Yeah, except it's

Re: [PATCH 3/5] git-diff.txt: group the [--] and [path...] templates

2013-04-24 Thread Ramkumar Ramachandra
Junio C Hamano wrote: You are missing the entire point. Yeah, okay: I'll drop this patch. I was just saying; I don't feel strongly about it at all. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at