Re: [PATCH 3/6] stash: simplify option parser for create

2013-05-13 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: The option parser for create unnecessarily checks $1 inside a case statement that matches $1 in the first place. Also, use $@, not $*, as our caller is expecting $1 $2, not $1c$2 (where c is the first character of IFS). The first part of the

Re: [PATCH 3/6] stash: simplify option parser for create

2013-05-13 Thread Ramkumar Ramachandra
Junio C Hamano wrote: The semi-user facing git stash create never was meant to take anything but a message sentence and $* is the proper way to say everything is meant for a single message (just like echo). Changing it to $@ will change the semantics in a big way. Ah, I see. As an