Re: [PATCH 4/6] index-pack: calculate {ref,ofs}_{first,last} early

2019-10-16 Thread Jeff King
On Wed, Oct 09, 2019 at 04:44:20PM -0700, Jonathan Tan wrote: > Whenever we make a struct base_data, immediately calculate its delta > children. This eliminates confusion as to when the > {ref,ofs}_{first,last} fields are initialized. That _seems_ like a good idea, but I'm a little worried just b

[PATCH 4/6] index-pack: calculate {ref,ofs}_{first,last} early

2019-10-09 Thread Jonathan Tan
Whenever we make a struct base_data, immediately calculate its delta children. This eliminates confusion as to when the {ref,ofs}_{first,last} fields are initialized. Signed-off-by: Jonathan Tan --- builtin/index-pack.c | 125 +-- 1 file changed, 61 insert