Re: [PATCH 4/6] pack-objects: stop respecting pack.writebitmaps

2014-06-10 Thread Jeff King
On Tue, Jun 10, 2014 at 02:07:37PM -0700, Junio C Hamano wrote: > > Another option is to track it to graduate to master during the next > > cycle. I.e., decide that the possible regression isn't a big deal. > > My gut feeling is that the last one is sufficient. These low level > subcommands that

Re: [PATCH 4/6] pack-objects: stop respecting pack.writebitmaps

2014-06-10 Thread Junio C Hamano
Jeff King writes: > I'm not sure what we want to do with this. It _is_ a possible regression > as explained above, but I really do find it improbable that anyone will > care. Even at GitHub, where we use a custom script instead of running > `git gc`, we hook into the repack code, and not directly

[PATCH 4/6] pack-objects: stop respecting pack.writebitmaps

2014-06-10 Thread Jeff King
The handling of the pack.writebitmaps config option originally happened in pack-objects, which is quite low-level. It would make more sense for drivers of pack-objects to read the config, and then manipulate pack-objects with command-line options. Recently, repack learned to do so, making the low-