Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

On 03/18/2014 11:00 AM, Benoit Pierre wrote: Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com --- builtin/checkout.c | 8 builtin/clone.c

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

Torsten Bögershausen tbo...@web.de writes: +int run_hook_with_custom_index(const char *index_file, const char *name, ...) +{ +const char *hook_env[3] = { NULL }; +char index[PATH_MAX]; Sorry being late with the review. Recently some effort has been put to replace the

[PATCH 4/7] commit: fix patch hunk editing with commit -p -m

Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com --- builtin/checkout.c | 8 builtin/clone.c | 4 ++-- builtin/commit.c| 35

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

On Mon, Mar 10, 2014 at 9:07 PM, Jeff King p...@peff.net wrote: On Mon, Mar 10, 2014 at 07:49:34PM +0100, Benoit Pierre wrote: Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. [...] This is a lot of

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

On Tue, Mar 11, 2014 at 06:56:02PM +0100, Benoit Pierre wrote: According to the original commit, the change to GIT_EDITOR is only here for hooks: commit 406400ce4f69e79b544dd3539a71b85d99331820 Author: Paolo Bonzini bonz...@gnu.org Date: Tue Feb 5 11:01:45 2008 +0100 git-commit:

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

Benoit Pierre benoit.pie...@gmail.com writes: diff --git a/builtin/checkout.c b/builtin/checkout.c index 5df3837..da423b2 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -53,10 +53,10 @@ struct checkout_opts { static int post_checkout_hook(struct commit *old, struct commit

[PATCH 4/7] commit: fix patch hunk editing with commit -p -m

Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com --- builtin/checkout.c| 8 +++ builtin/clone.c | 4 ++--

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

On Mon, Mar 10, 2014 at 07:49:34PM +0100, Benoit Pierre wrote: Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com --- builtin/checkout.c

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

Jeff King p...@peff.net writes: On Mon, Mar 10, 2014 at 07:49:34PM +0100, Benoit Pierre wrote: Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com ---