Re: [PATCH 5/5] difftool: Use symlinks when diffing against the worktree

2012-07-22 Thread Junio C Hamano
David Aguilar writes: > + # Do not copy back files when symlinks are used > + if ($symlinks) { > + exit(0); > + } > + Isn't this a bit risky, depending on the behaviour of the tool that eventually lead the user to invoke his favorite editor to muck with the files in the t

[PATCH 5/5] difftool: Use symlinks when diffing against the worktree

2012-07-22 Thread David Aguilar
Teach difftool's --dir-diff mode to use symlinks to represent files from the working copy, and make it the default behavior for the non-Windows platforms. Using symlinks is simpler and safer since we do not need to worry about copying files back into the worktree. The old behavior is still availab

[PATCH 5/5] difftool: Use symlinks when diffing against the worktree

2012-07-22 Thread David Aguilar
Teach difftool's --dir-diff mode to use symlinks to represent files from the working copy, and make it the default behavior for the non-Windows platforms. Using symlinks is simpler and safer since we do not need to worry about copying files back into the worktree. The old behavior is still availab