Michael Haggerty writes:
> Contrariwise, I thought about it again and believe that it *is*
> important for the docstring to mention explicitly that the return value
> is architecture-dependent
As it gives an internal hash value which should not leak to the
outside world (e.g. stored in a file or
Nicolas, thanks for the very fast feedback!
On 02/21/2014 06:33 PM, Nicolas Pitre wrote:
> On Fri, 21 Feb 2014, Michael Haggerty wrote:
>
>> Signed-off-by: Michael Haggerty
>
> Minor nits below.
>
>
>> ---
>> object.c | 23 ++-
>> object.h | 7 +++
>> 2 files changed
On Fri, 21 Feb 2014, Michael Haggerty wrote:
> Signed-off-by: Michael Haggerty
Minor nits below.
> ---
> object.c | 23 ++-
> object.h | 7 +++
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/object.c b/object.c
> index 584f7ac..c34e225 100644
> -
Signed-off-by: Michael Haggerty
---
object.c | 23 ++-
object.h | 7 +++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/object.c b/object.c
index 584f7ac..c34e225 100644
--- a/object.c
+++ b/object.c
@@ -43,14 +43,26 @@ int type_from_string(const char *str
4 matches
Mail list logo