Re: [PATCH 6/6] Document some functions defined in object.c

2014-02-24 Thread Junio C Hamano
Michael Haggerty writes: > Contrariwise, I thought about it again and believe that it *is* > important for the docstring to mention explicitly that the return value > is architecture-dependent As it gives an internal hash value which should not leak to the outside world (e.g. stored in a file or

Re: [PATCH 6/6] Document some functions defined in object.c

2014-02-24 Thread Michael Haggerty
Nicolas, thanks for the very fast feedback! On 02/21/2014 06:33 PM, Nicolas Pitre wrote: > On Fri, 21 Feb 2014, Michael Haggerty wrote: > >> Signed-off-by: Michael Haggerty > > Minor nits below. > > >> --- >> object.c | 23 ++- >> object.h | 7 +++ >> 2 files changed

Re: [PATCH 6/6] Document some functions defined in object.c

2014-02-21 Thread Nicolas Pitre
On Fri, 21 Feb 2014, Michael Haggerty wrote: > Signed-off-by: Michael Haggerty Minor nits below. > --- > object.c | 23 ++- > object.h | 7 +++ > 2 files changed, 29 insertions(+), 1 deletion(-) > > diff --git a/object.c b/object.c > index 584f7ac..c34e225 100644 > -

[PATCH 6/6] Document some functions defined in object.c

2014-02-21 Thread Michael Haggerty
Signed-off-by: Michael Haggerty --- object.c | 23 ++- object.h | 7 +++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/object.c b/object.c index 584f7ac..c34e225 100644 --- a/object.c +++ b/object.c @@ -43,14 +43,26 @@ int type_from_string(const char *str