[PATCH 6/7] Remove unused and bad gettext block from git-am
Gettext message should not start with '-' nor '--'. Since the '-d' and '--dotest' options are not exist in OPTIONS_SPEC variable, so it's safe to remove the block. Signed-off-by: Jiang Xin worldhello@gmail.com --- git-am.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/git-am.sh b/git-am.sh index 20c1a..cfa63 100755 --- a/git-am.sh +++ b/git-am.sh @@ -413,9 +413,6 @@ it will be removed. Please do not use it anymore.) abort=t ;; --rebasing) rebasing=t threeway=t ;; - -d|--dotest) - die $(gettext -d option is no longer supported. Do not use.) - ;; --resolvemsg) shift; resolvemsg=$1 ;; --whitespace|--directory|--exclude|--include) -- 1.7.11.2.259.g37fc0e1 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] Remove unused and bad gettext block from git-am
On 07/21/2012 05:50 PM, Jiang Xin wrote: Gettext message s/message/messages/ I think. should not start with '-' nor '--'. Since the '-d' and '--dotest' options are not exist s/are not/do not/ in OPTIONS_SPEC variable, s/OPTIONS_SPEC/the OPTIONS_SPEC/ so it's safe to remove the block. This so is redundant, in light of the earlier Since. I'd just remove it. Regards, Stefano -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] Remove unused and bad gettext block from git-am
2012/7/22 Stefano Lattarini stefano.lattar...@gmail.com: s/message/messages/ I think. s/are not/do not/ This so is redundant, in light of the earlier Since. I'd just remove it. Thanks, Stefano. New series of patches are generated and sent to this list. -- Jiang Xin -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
