Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()

2014-05-01 Thread David Kastrup
Junio C Hamano gits...@pobox.com writes: The point immediately before it is about having SP after the control keyword. Follow it. Signed-off-by: Junio C Hamano gits...@pobox.com --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()

2014-05-01 Thread Junio C Hamano
David Kastrup d...@gnu.org writes: - - We try to avoid assignments inside if(). + - We try to avoid assignments inside if () condition. That's not grammatical. OK, ... inside the condition part of an if () statement. then? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()

2014-05-01 Thread David Kastrup
Junio C Hamano gits...@pobox.com writes: David Kastrup d...@gnu.org writes: - - We try to avoid assignments inside if(). + - We try to avoid assignments inside if () condition. That's not grammatical. OK, ... inside the condition part of an if () statement. then? ... in

[PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()

2014-04-30 Thread Junio C Hamano
The point immediately before it is about having SP after the control keyword. Follow it. Signed-off-by: Junio C Hamano gits...@pobox.com --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines