On Tue, Apr 10, 2018 at 4:17 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>>> That test was fixed a week ago:
>>> https://github.com/git/git/commit/a99d903f21d102a5768f19157085a9733aeb68dd
>>
>> Well, you cannot expect any reviewer to know about a change that has
>> never been sent to the
Junio C Hamano writes:
>> That test was fixed a week ago:
>> https://github.com/git/git/commit/a99d903f21d102a5768f19157085a9733aeb68dd
>
> Well, you cannot expect any reviewer to know about a change that has
> never been sent to the list and has never been part of even 'pu'
> branch, no matter h
Ben Toews writes:
>> H, what vintage of our codebase is this patch based on? Did I
>> miss a patch that removes these lines
>>
>>
>> printf ' ' >sigblanknonlfile
>> get_tag_header blanknonlfile-signed-tag $commit commit $time >expect
>> echo '-BEGIN PGP SIGNATURE-' >
On Tue, Apr 10, 2018 at 3:44 AM, Junio C Hamano wrote:
> Ben Toews writes:
>
>> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
>> index ee093b393d..e3f1e014aa 100755
>> --- a/t/t7004-tag.sh
>> +++ b/t/t7004-tag.sh
>> @@ -1059,6 +1059,17 @@ test_expect_success GPG \
>> git tag -v blanknonlfile
Ben Toews writes:
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index ee093b393d..e3f1e014aa 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1059,6 +1059,17 @@ test_expect_success GPG \
> git tag -v blanknonlfile-signed-tag
> '
>
> +test_expect_success GPG 'signed tag with
On Mon, Apr 9, 2018 at 4:41 PM, Ben Toews wrote:
> From: Jeff King
>
> A signed tag has a detached signature like this:
>
> object ...
> [...more header...]
>
> This is the tag body.
>
> -BEGIN PGP SIGNATURE-
> [opaque gpg data]
> -END PGP SIGNATURE-
>
> Our parser fin
From: Jeff King
A signed tag has a detached signature like this:
object ...
[...more header...]
This is the tag body.
-BEGIN PGP SIGNATURE-
[opaque gpg data]
-END PGP SIGNATURE-
Our parser finds the _first_ line that appears to start a
PGP signature block, meaning
7 matches
Mail list logo
