[PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Johannes Sixt
From: Johannes Sixt j...@kdbg.org Two tests use GIT_TRACE=3 to dump debugging information of git. On Windows, however, bash is unable to set up file descriptor 3 correctly for its child process, so that git reports Bad file descriptor on every trace attempt. The 'git clone' test succeeds

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Jeff King
On Wed, Mar 20, 2013 at 09:24:44AM +0100, Johannes Sixt wrote: From: Johannes Sixt j...@kdbg.org Two tests use GIT_TRACE=3 to dump debugging information of git. On Windows, however, bash is unable to set up file descriptor 3 correctly for its child process, so that git reports Bad file

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Johannes Sixt
Am 3/20/2013 10:33, schrieb Jeff King: On Wed, Mar 20, 2013 at 09:24:44AM +0100, Johannes Sixt wrote: From: Johannes Sixt j...@kdbg.org Two tests use GIT_TRACE=3 to dump debugging information of git. On Windows, however, bash is unable to set up file descriptor 3 correctly for its child

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Jeff King
On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote: I think that is OK, but I'm curious why this is a problem _now_, and not with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also just calling write() to descriptor 3. Before this change, both affected commands

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Jeff King
On Wed, Mar 20, 2013 at 01:06:07PM -0400, Jeff King wrote: On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote: I think that is OK, but I'm curious why this is a problem _now_, and not with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also just calling write()

Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git

2013-03-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: Also, though I think your use of stderr is probably OK, might it be a little more robust against future output changes to use: GIT_TRACE_PACKET=$PWD/$U.D git clone ... to write directly to the file. The original GIT_DEBUG_SEND_PACK did not support such