Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
On 10 Nov 2016, at 22:34, Junio C Hamano wrote:
> Lars Schneider writes:
>
>>> I've followed what was available at the public-inbox archive, but it
>>> is unclear what the conclusion was.
>>>
>>> For the first one your "how about" non-patch, to which Peff said
>>> "that's simple and good", looked good to me as well, but is it
>>> available as a final patch that I can just take and apply (otherwise
>>> I think I can do the munging myself, but I'd rather be spoon-fed
>>> when able ;-).
>>
>> Sure! Here you go:
>> http://public-inbox.org/git/20161110111348.61580-1-larsxschnei...@gmail.com/
>>
>>
>>> I do not have a strong opinion on the second one. For an interim
>>> solution, disabling webserver tests certainly is expedite and safe,
>>> so I am fine taking it as-is, but I may have missed strong
>>> objections.
>>
>> I haven't seen strong objections either. Just for reference, here is the
>> patch:
>> http://public-inbox.org/git/20161017002550.88782-3-larsxschnei...@gmail.com/
>
> Thanks. Picked up both of them.
Thanks! This makes "next" pass, again:
https://travis-ci.org/git/git/builds/174946111
BTW: If you want to learn about the build status of "git/git" branches on the
command line then you can use this snippet:
$ branch=next; echo "$branch: $(curl -s
https://api.travis-ci.org/repos/git/git/branches/$branch | perl -lape
's/.*"state":"(\w+)".*"sha":"(\w{7}).*/$1 $2/g')"
Cheers,
Lars
Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
Lars Schneider writes: >> I've followed what was available at the public-inbox archive, but it >> is unclear what the conclusion was. >> >> For the first one your "how about" non-patch, to which Peff said >> "that's simple and good", looked good to me as well, but is it >> available as a final patch that I can just take and apply (otherwise >> I think I can do the munging myself, but I'd rather be spoon-fed >> when able ;-). > > Sure! Here you go: > http://public-inbox.org/git/20161110111348.61580-1-larsxschnei...@gmail.com/ > > >> I do not have a strong opinion on the second one. For an interim >> solution, disabling webserver tests certainly is expedite and safe, >> so I am fine taking it as-is, but I may have missed strong >> objections. > > I haven't seen strong objections either. Just for reference, here is the > patch: > http://public-inbox.org/git/20161017002550.88782-3-larsxschnei...@gmail.com/ Thanks. Picked up both of them.
Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
> On 10 Nov 2016, at 00:39, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> Apple removed the OpenSSL header files in macOS and therefore Git does >> not build out of the box on macOS anymore. See previous discussion with >> Torsten here: http://public-inbox.org/git/565b3036.8000...@web.de/ >> >> This mini series makes Git build out of the box on macOS, again, and >> disables the HTTPD tests on macOS TravisCI as they don't work anymore >> with the new macOS TravisCI default image: >> https://blog.travis-ci.com/2016-10-04-osx-73-default-image-live/ >> >> Thanks, >> Lars >> >> >> Lars Schneider (2): >> config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11 >> travis-ci: disable GIT_TEST_HTTPD for macOS >> >> .travis.yml | 3 ++- >> config.mak.uname | 6 ++ >> 2 files changed, 8 insertions(+), 1 deletion(-) > > I've followed what was available at the public-inbox archive, but it > is unclear what the conclusion was. > > For the first one your "how about" non-patch, to which Peff said > "that's simple and good", looked good to me as well, but is it > available as a final patch that I can just take and apply (otherwise > I think I can do the munging myself, but I'd rather be spoon-fed > when able ;-). Sure! Here you go: http://public-inbox.org/git/20161110111348.61580-1-larsxschnei...@gmail.com/ > I do not have a strong opinion on the second one. For an interim > solution, disabling webserver tests certainly is expedite and safe, > so I am fine taking it as-is, but I may have missed strong > objections. I haven't seen strong objections either. Just for reference, here is the patch: http://public-inbox.org/git/20161017002550.88782-3-larsxschnei...@gmail.com/ I hope you're well, again!! - Lars
Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
On 10/11/16 00:39, Junio C Hamano wrote: I've followed what was available at the public-inbox archive, but it is unclear what the conclusion was. For the first one your "how about" non-patch, to which Peff said "that's simple and good", looked good to me as well, but is it available as a final patch that I can just take and apply (otherwise I think I can do the munging myself, but I'd rather be spoon-fed when able ;-). If you can munge the Peff version that may be easiest ? I couldn't find a branch in your repo, but am happy to review whatever shows up there and in pu.
Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
larsxschnei...@gmail.com writes: > From: Lars Schneider > > Apple removed the OpenSSL header files in macOS and therefore Git does > not build out of the box on macOS anymore. See previous discussion with > Torsten here: http://public-inbox.org/git/565b3036.8000...@web.de/ > > This mini series makes Git build out of the box on macOS, again, and > disables the HTTPD tests on macOS TravisCI as they don't work anymore > with the new macOS TravisCI default image: > https://blog.travis-ci.com/2016-10-04-osx-73-default-image-live/ > > Thanks, > Lars > > > Lars Schneider (2): > config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11 > travis-ci: disable GIT_TEST_HTTPD for macOS > > .travis.yml | 3 ++- > config.mak.uname | 6 ++ > 2 files changed, 8 insertions(+), 1 deletion(-) I've followed what was available at the public-inbox archive, but it is unclear what the conclusion was. For the first one your "how about" non-patch, to which Peff said "that's simple and good", looked good to me as well, but is it available as a final patch that I can just take and apply (otherwise I think I can do the munging myself, but I'd rather be spoon-fed when able ;-). I do not have a strong opinion on the second one. For an interim solution, disabling webserver tests certainly is expedite and safe, so I am fine taking it as-is, but I may have missed strong objections. Thanks.
[PATCH v1 0/2] Fix default macOS build locally and on Travis CI
From: Lars Schneider Apple removed the OpenSSL header files in macOS and therefore Git does not build out of the box on macOS anymore. See previous discussion with Torsten here: http://public-inbox.org/git/565b3036.8000...@web.de/ This mini series makes Git build out of the box on macOS, again, and disables the HTTPD tests on macOS TravisCI as they don't work anymore with the new macOS TravisCI default image: https://blog.travis-ci.com/2016-10-04-osx-73-default-image-live/ Thanks, Lars Lars Schneider (2): config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11 travis-ci: disable GIT_TEST_HTTPD for macOS .travis.yml | 3 ++- config.mak.uname | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) -- 2.10.0
