Re: [PATCH v11 26/41] walker.c: use ref transaction for ref updates

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would fail we would end up returning from the function without free()ing the msg

Re: [PATCH v11 26/41] walker.c: use ref transaction for ref updates

2014-05-28 Thread Ronnie Sahlberg
On Wed, May 28, 2014 at 12:56 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would

[PATCH v11 26/41] walker.c: use ref transaction for ref updates

2014-05-27 Thread Ronnie Sahlberg
Switch to using ref transactions in walker_fetch(). As part of the refactoring to use ref transactions we also fix a potential memory leak where in the original code if write_ref_sha1() would fail we would end up returning from the function without free()ing the msg string. This changes the