Re: [PATCH v12 0/8] submodule inline diff format

2016-08-31 Thread Junio C Hamano
Jacob Keller writes: > @@ -523,8 +523,10 @@ char *git_pathdup_submodule(const char *path, const char > *fmt, ...) > va_start(args, fmt); > err = do_submodule_path(&buf, path, fmt, args); > va_end(args); > - if (err) > + if (err) { > + strbuf_release(&buf); >

Re: [PATCH v12 0/8] submodule inline diff format

2016-08-31 Thread Stefan Beller
On Wed, Aug 31, 2016 at 4:27 PM, Jacob Keller wrote: > From: Jacob Keller > > Hopefully the final revision here. I've squashed in the memory leak fix > suggested by Stefan, and the suggested changes from Junio, including his > re-worded commit messages. > > interdiff between v11 and v12 > diff --

[PATCH v12 0/8] submodule inline diff format

2016-08-31 Thread Jacob Keller
From: Jacob Keller Hopefully the final revision here. I've squashed in the memory leak fix suggested by Stefan, and the suggested changes from Junio, including his re-worded commit messages. interdiff between v11 and v12 diff --git c/path.c w/path.c index 3dbc4478a4aa..ba60c9849ef7 100644 --- c/