Re: [PATCH v15 14/27] t6030: no cleanup with bad merge base

2016-10-15 Thread Pranit Bauva
Hey Junio, On Sat, Oct 15, 2016 at 3:13 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +test_expect_success 'check whether bisection cleanup is not done with bad >> merges' ' >> + git bisect start $HASH7 $SIDE_HASH7 && >> +

Re: [PATCH v15 14/27] t6030: no cleanup with bad merge base

2016-10-14 Thread Junio C Hamano
Pranit Bauva writes: > +test_expect_success 'check whether bisection cleanup is not done with bad > merges' ' > + git bisect start $HASH7 $SIDE_HASH7 && > + test_expect_failure git bisect bad >out 2>out && I think you meant "test_must_fail" here. > +

[PATCH v15 14/27] t6030: no cleanup with bad merge base

2016-10-14 Thread Pranit Bauva
The bisection cleanup should be performed with bad merge base so that the user can return to its original position with `git bisect reset`. Mentored-by: Lars Schneider Mentored-by: Christian Couder Signed-off-by: Pranit Bauva