[PATCH v2] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread John Keeping
This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit cannot be updated to use Git 1.8.0 or newer, so let's not do that. On top of the revert, also add comments so that

Re: [PATCH v2] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com On Sun, Mar 3, 2013 at 7:03 PM, John Keeping j...@keeping.me.uk wrote: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means

Re: [PATCH v2] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Johan Herland
On Mon, Mar 4, 2013 at 1:03 AM, John Keeping j...@keeping.me.uk wrote: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit cannot be updated to use Git 1.8.0 or

Re: [PATCH v2] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Junio C Hamano
Jason A. Donenfeld ja...@zx2c4.com writes: Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com I suspect that many people outside CGit circle may not know who this Jason (who never appeared in git@vger.kernel.org) is, and are wondering in what capacity he is sending a S-o-b for somebody else's

Re: [PATCH v2] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Jason A. Donenfeld
On Sun, Mar 3, 2013 at 10:42 PM, Junio C Hamano gits...@pobox.com wrote: I suspect that many people outside CGit circle may not know who this Jason That active contributor is Jason. The repository has also been moved to Jason's http://git.zx2c4.com/cgit/ So, thanks, Jason and John for your