Re: [PATCH v2] archive: initialize archivers earlier

2018-10-22 Thread Josh Steadmon
On 2018.10.22 20:06, Jeff King wrote: > On Mon, Oct 22, 2018 at 04:51:27PM -0700, Josh Steadmon wrote: > > > > > +test_expect_success GZIP 'git archive with --output and --remote uses > > > > expected format' ' > > > > + git archive --output=d5.tgz --remote=. HEAD && > > > > + gzip

Re: [PATCH v2] archive: initialize archivers earlier

2018-10-22 Thread Jeff King
On Mon, Oct 22, 2018 at 04:51:27PM -0700, Josh Steadmon wrote: > > > +test_expect_success GZIP 'git archive with --output and --remote uses > > > expected format' ' > > > + git archive --output=d5.tgz --remote=. HEAD && > > > + gzip -d -c < d5.tgz > d5.tar && > > > + test_cmp_bin b.tar d5.tar >

Re: [PATCH v2] archive: initialize archivers earlier

2018-10-22 Thread Josh Steadmon
On 2018.10.22 18:35, Jeff King wrote: > On Mon, Oct 22, 2018 at 02:48:11PM -0700, stead...@google.com wrote: > > > Initialize archivers as soon as possible when running git-archive and > > git-upload-archive. Various non-obvious behavior depends on having the > > archivers initialized, such as

Re: [PATCH v2] archive: initialize archivers earlier

2018-10-22 Thread Jeff King
On Mon, Oct 22, 2018 at 02:48:11PM -0700, stead...@google.com wrote: > Initialize archivers as soon as possible when running git-archive and > git-upload-archive. Various non-obvious behavior depends on having the > archivers initialized, such as determining the desired archival format > from the

[PATCH v2] archive: initialize archivers earlier

2018-10-22 Thread steadmon
Initialize archivers as soon as possible when running git-archive and git-upload-archive. Various non-obvious behavior depends on having the archivers initialized, such as determining the desired archival format from the provided filename. Since 08716b3c11 ("archive: refactor file extension