Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

2013-03-31 Thread Ramkumar Ramachandra
Junio C Hamano wrote: sub foo ($) { my ($arg) = @_; print $arg\n; } sub bar { my ($arg) = @_; print $arg\n; } my @baz = (100, 101, 102); foo @baz; # says 3 bar @baz; # says 100 Ouch. Please drop this patch; I'll resubmit when I feel confident about my change. This

Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

2013-03-31 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: sub foo ($) { my ($arg) = @_; print $arg\n; } sub bar { my ($arg) = @_; print $arg\n; } my @baz = (100, 101, 102); foo @baz; # says 3 bar @baz; # says 100 Ouch. Please drop this patch; I'll

[PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

2013-03-28 Thread Ramkumar Ramachandra
Running perlcritic with gentle severity reports six problems. The following lists the line numbers on which the problems occur, along with a description of the problem. This patch fixes them all, after carefully considering the consequences. 516: Contrary to common belief, subroutine prototypes

Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

2013-03-28 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: Junio: In future, please tell me explicitly that you're expecting a re-roll with an updated commit message. It wasn't obvious to me at all. When there are questions in response to a patch, there are two possibilities: * temporary brainfart --- sorry for the

Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

2013-03-28 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Running perlcritic with gentle severity reports six problems. The following lists the line numbers on which the problems occur, along with a description of the problem. This patch fixes them all, Thanks. after carefully considering the