Re: [PATCH v2] gitk: read and write a repository specific configuration file

2012-12-05 Thread Marc Branchaud
On 12-12-04 07:49 PM, Łukasz Stelmach wrote:
 Enable gitk read and write repository specific configuration
 file: .git/k if the file exists. To make gitk use the local
 file simply create one, e.g. with the touch(1) command.
 
 This is very useful if one uses different views for different
 repositories. Now there is no need to store all of them in
 ~/.gitk and make the views list needlesly long.

s/needlesly/needlessly/

M.

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] gitk: read and write a repository specific configuration file

2012-12-04 Thread Łukasz Stelmach
Enable gitk read and write repository specific configuration
file: .git/k if the file exists. To make gitk use the local
file simply create one, e.g. with the touch(1) command.

This is very useful if one uses different views for different
repositories. Now there is no need to store all of them in
~/.gitk and make the views list needlesly long.

Signed-off-by: Łukasz Stelmach stl...@poczta.fm
---

Same as before but rebased onto Paul's repository.

 gitk |   25 ++---
 1 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/gitk b/gitk
index 379582a..c6b7dc3 100755
--- a/gitk
+++ b/gitk
@@ -2703,7 +2703,7 @@ proc doprogupdate {} {
 
 proc savestuff {w} {
 global canv canv2 canv3 mainfont textfont uifont tabstop
-global stuffsaved findmergefiles maxgraphpct
+global stuffsaved findmergefiles maxgraphpct gitdir
 global maxwidth showneartags showlocalchanges
 global viewname viewfiles viewargs viewargscmd viewperm nextviewnum
 global cmitmode wrapcomment datetimeformat limitdiffs
@@ -2714,10 +2714,12 @@ proc savestuff {w} {
 if {$stuffsaved} return
 if {![winfo viewable .]} return
 catch {
-   if {[file exists ~/.gitk-new]} {file delete -force ~/.gitk-new}
-   set f [open ~/.gitk-new w]
+   set fn [expr [file exists [file join $gitdir k]] ? \
+   {[file join $gitdir k-new]} : {~/.gitk-new}]
+   if {[file exists $fn]} {file delete -force $fn}
+   set f [open $fn  w]
if {$::tcl_platform(platform) eq {windows}} {
-   file attributes ~/.gitk-new -hidden true
+   catch {file attributes ~/.gitk-new -hidden true}
}
puts $f [list set mainfont $mainfont]
puts $f [list set textfont $textfont]
@@ -2769,7 +2771,7 @@ proc savestuff {w} {
}
puts $f }
close $f
-   file rename -force ~/.gitk-new ~/.gitk
+   file rename -force $fn [regsub {\-new$} $fn {}]
 }
 set stuffsaved 1
 }
@@ -11723,7 +11725,14 @@ namespace import ::msgcat::mc
 ## And eventually load the actual message catalog
 ::msgcat::mcload $gitk_msgsdir
 
+# check that we can find a .git directory somewhere...
+if {[catch {set gitdir [exec git rev-parse --git-dir]}]} {
+show_error {} . [mc Cannot find a git repository here.]
+exit 1
+}
+
 catch {source ~/.gitk}
+catch {source [file join $gitdir k]}
 
 parsefont mainfont $mainfont
 eval font create mainfont [fontflags mainfont]
@@ -11740,12 +11749,6 @@ setui $uicolor
 
 setoptions
 
-# check that we can find a .git directory somewhere...
-if {[catch {set gitdir [exec git rev-parse --git-dir]}]} {
-show_error {} . [mc Cannot find a git repository here.]
-exit 1
-}
-
 set selecthead {}
 set selectheadid {}
 
-- 
1.7.8.6

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html