Re: [PATCH v2] remotes-hg: bugfix for fetching non local remotes

2013-07-24 Thread Jörn Hees
On 25 Jul 2013, at 01:02, Junio C Hamano wrote: > Joern Hees writes: >> >> Changing shared_path to ".git/hg/.shared" will solve this problem > > Here you say "shared" and the code says "share"; which one is > preferred (I know either would work, but we would want to be > consistent). > > I'd

Re: [PATCH v2] remotes-hg: bugfix for fetching non local remotes

2013-07-24 Thread Junio C Hamano
Joern Hees writes: > 6796d49 introduced a bug by making shared_path == ".git/hg' which > will most likely exist already, causing a new remote never to be > cloned and subsequently causing hg.share to fail with error msg: > "mercurial.error.RepoError: repository .git/hg not found" > > Changing sha

[PATCH v2] remotes-hg: bugfix for fetching non local remotes

2013-07-24 Thread Joern Hees
6796d49 introduced a bug by making shared_path == ".git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: "mercurial.error.RepoError: repository .git/hg not found" Changing shared_path to ".git/hg/.shared" wi