[PATCH v2] rev-parse: Check argc before using argv[i+1]

Without this patch, git-rev-parse --prefix, --default, or --resolve-git-dir, without a value argument, would result in a segfault. Instead, die() with a message. Signed-off-by: David Sharp dhsh...@google.com --- builtin/rev-parse.c | 17 +++-- 1 file changed, 11 insertions(+), 6

Re: [PATCH v2] rev-parse: Check argc before using argv[i+1]

David Sharp dhsh...@google.com writes: Without this patch, git-rev-parse --prefix, --default, or --resolve-git-dir, without a value argument, would result in a segfault. Instead, die() with a message. When I sent the review message, I actually was on the fence between checking i vs argc and

Re: [PATCH v2] rev-parse: Check argc before using argv[i+1]

On Tue, Jan 28, 2014 at 1:43 PM, Junio C Hamano gits...@pobox.com wrote: David Sharp dhsh...@google.com writes: Without this patch, git-rev-parse --prefix, --default, or --resolve-git-dir, without a value argument, would result in a segfault. Instead, die() with a message. When I sent the

Re: [PATCH v2] rev-parse: Check argc before using argv[i+1]

On Tue, Jan 28, 2014 at 2:01 PM, Johannes Sixt j...@kdbg.org wrote: Am 28.01.2014 22:21, schrieb David Sharp: @@ -738,9 +740,12 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix) continue; } if