Re: [PATCH v2] submodule: add 'deinit' command

2012-12-13 Thread Marc Branchaud
On 12-12-12 05:25 PM, Jens Lehmann wrote: So unless people agree that deinit should also remove the work tree I'll prepare some patches teaching all git commands to consistently ignore deinitialized submodules. Opinions? I agree with Trevor's suggestion that deinit should restore the user to

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Michael J Gruber
Jens Lehmann venit, vidit, dixit 04.12.2012 22:48: With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But currently there is no easy way he could tell git he does not care about a

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Jens Lehmann
Am 12.12.2012 16:08, schrieb Michael J Gruber: Jens Lehmann venit, vidit, dixit 04.12.2012 22:48: With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But currently there is no easy

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Especially as I suspect the number of submodule users having customized those in .git/config is not that high ... I thought the point of deinit was to say I am not interested in having a checkout of these submodules in my working tree anymore. The user

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Jens Lehmann
Am 12.12.2012 20:32, schrieb Junio C Hamano: Jens Lehmann jens.lehm...@web.de writes: Especially as I suspect the number of submodule users having customized those in .git/config is not that high ... I thought the point of deinit was to say I am not interested in having a checkout of

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: So unless people agree that deinit should also remove the work tree I'll prepare some patches teaching all git commands to consistently ignore deinitialized submodules. Opinions? While I agree that consistency is good, deinit that does not remove the

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread W. Trevor King
On Wed, Dec 12, 2012 at 02:34:47PM -0800, Junio C Hamano wrote: Jens Lehmann jens.lehm...@web.de writes: So unless people agree that deinit should also remove the work tree I'll prepare some patches teaching all git commands to consistently ignore deinitialized submodules. Opinions?

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread Junio C Hamano
W. Trevor King wk...@tremily.us writes: Should `deinit` remove the submodule checkout, replace it with the original gitlink, and clear the .git/config information then? That would restore the user to the state they'd be in if they were never interested in the submodule. AFAIU, restore the

Re: [PATCH v2] submodule: add 'deinit' command

2012-12-12 Thread W. Trevor King
On Wed, Dec 12, 2012 at 03:35:59PM -0800, Junio C Hamano wrote: W. Trevor King wk...@tremily.us writes: Should `deinit` remove the submodule checkout, replace it with the original gitlink, and clear the .git/config information then? That would restore the user to the state they'd be in

[PATCH v2] submodule: add 'deinit' command

2012-12-04 Thread Jens Lehmann
With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But currently there is no easy way he could tell git he does not care about a submodule anymore and wants to get rid of his local work