Re: [PATCH v2 00/16] Remove submodule from files-backend.c

[Duy Nguyen]

On Sat, Feb 18, 2017 at 1:35 AM, Junio C Hamano  wrote:
> Nguyễn Thái Ngọc Duy   writes:
>
>> I'll be sending two more follow-up series, if you are interested, soon:
>>
>> 1) v2 of nd/worktree-gc-protection
>>
>> which kills parse_ref() in worktree.c _and_ set_worktree_head_symref()
>> in files-backend.c. Both are bad things that should not have happened.
>> (PS. The topic name is misleading as this is mostly about eliminating
>> warts, unless Junio intended to combine my second series as well)
>
> Your description sounded that these two are just preparatory step
> for the main one that would soon follow, and that was why these two
> patches landed on a topic named as such without any of its friends
> (which were yet to come).  If you prefer to keep these a separate
> preparatory step from the remainder and have them graduate sooner,
> let's do so, as that is my preference as well.
>
> Rename it "nd/worktree-kill-parse-ref" perhaps?

That's exactly my branch name (minus the nd/)
-- 
Duy

Re: [PATCH v2 00/16] Remove submodule from files-backend.c

[Junio C Hamano]

Junio C Hamano  writes:

> Nguyễn Thái Ngọc Duy   writes:
>
>> I'll be sending two more follow-up series, if you are interested, soon:
>>
>> 1) v2 of nd/worktree-gc-protection
>> ...
>> 2) the real worktree-gc-protection
>>
>> This series adds a bunch of new refs API, enough for revision.c to
>> traverses all sorts of refs with a ref store instead of "submodule".
>> Many _submodule API are removed as a result because they no longer
>> have any callers (yay!). One of them remains though.
>
> Yay indeed.

Having said all that, I have a bad news.

I won't be able to queue this as-is, as this heavily conflicts with
mh/ref-remove-empty-directory that has already been cooking in
'next' for some time.  I started trying conflict resolution myself
and it seemed doable, but stopped after finishing perhaps 40% of it,
as I cannot afford the same amount of time for conflict resolution
every time the series gets rerolled.

If the topic is rebased on the result of doing:

 - checking out master^0
 - merging mh/ref-remove-empty-directory on it
 - mergeing mh/submodule-hash on the result

I suspect that we might be able start cooking it in 'pu' sooner, but
I cannot spend any more time on this topic today so I'd stop analyzing
the situation for now.

Re: [PATCH v2 00/16] Remove submodule from files-backend.c

[Junio C Hamano]

Nguyễn Thái Ngọc Duy   writes:

> I'll be sending two more follow-up series, if you are interested, soon:
>
> 1) v2 of nd/worktree-gc-protection
>
> which kills parse_ref() in worktree.c _and_ set_worktree_head_symref()
> in files-backend.c. Both are bad things that should not have happened.
> (PS. The topic name is misleading as this is mostly about eliminating
> warts, unless Junio intended to combine my second series as well)

Your description sounded that these two are just preparatory step
for the main one that would soon follow, and that was why these two
patches landed on a topic named as such without any of its friends
(which were yet to come).  If you prefer to keep these a separate
preparatory step from the remainder and have them graduate sooner,
let's do so, as that is my preference as well.  

Rename it "nd/worktree-kill-parse-ref" perhaps?

> This series introduces get_worktree_ref_store() and adds two new APIs
> refs_resolve_ref_unsafe() and refs_create_symref(). I'm still not sure
> if the refs_ prefix is good naming, but I had to pick something to get
> things going. Name suggestions are welcome.

> 2) the real worktree-gc-protection
>
> This series adds a bunch of new refs API, enough for revision.c to
> traverses all sorts of refs with a ref store instead of "submodule".
> Many _submodule API are removed as a result because they no longer
> have any callers (yay!). One of them remains though.

Yay indeed.

Re: [PATCH v2 00/16] Remove submodule from files-backend.c

[Stefan Beller]

This series looks good to me.

Thanks,
Stefan

[PATCH v2 00/16] Remove submodule from files-backend.c

[Nguyễn Thái Ngọc Duy]

binbSOlqAf8r_.bin
Description: plain