Re: [PATCH v2 00/19] add strbuf_set operations

2014-06-12 Thread Jeremiah Mahler
Eric, On Wed, Jun 11, 2014 at 04:09:17AM -0400, Eric Sunshine wrote: > On Mon, Jun 9, 2014 at 6:19 PM, Jeremiah Mahler wrote: > > Version 2 of the patch set to add strbuf_set operations. > > > > Includes suggestions from Eric Sunshine [1]: > > > > [...snip...] > > ... > > Food for thought: This

Re: [PATCH v2 00/19] add strbuf_set operations

2014-06-11 Thread Eric Sunshine
On Mon, Jun 9, 2014 at 6:19 PM, Jeremiah Mahler wrote: > Version 2 of the patch set to add strbuf_set operations. > > Includes suggestions from Eric Sunshine [1]: > > [...snip...] > > Using strbuf_set before a sequence of adds can be confusing. But using > strbuf_add when nothing important was be

[PATCH v2 00/19] add strbuf_set operations

2014-06-09 Thread Jeremiah Mahler
Version 2 of the patch set to add strbuf_set operations. Includes suggestions from Eric Sunshine [1]: - New operations and their documentation placed in one patch. - Less ambiguous documentation: "Replace the buffer content with [...]" - Use imperative mood in log messages. - Don't use