Re: [PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-09-29 Thread Jakub Narębski
W dniu 26.09.2016 o 00:52, Junio C Hamano pisze: > Vasco Almeida writes: >> my $status_fmt = '%12s %12s %s'; >> -my $status_head = sprintf($status_fmt, 'staged', 'unstaged', 'path'); >> +my $status_head = sprintf($status_fmt, __('staged'), __('unstaged'), >> __('path')); > > Wouldn't it make

Re: [PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-09-28 Thread Junio C Hamano
Vasco Almeida writes: > As far as I understand, %12s means that the argument printed will have > a minimum length of 12 columns. So if the translation of 'stage' is > longer than 12 it will be printed fully no matter what. Though in that > case, the header will not be align correctly anymore: Ex

Re: [PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-09-28 Thread Duy Nguyen
On Wed, Sep 28, 2016 at 7:43 PM, Vasco Almeida wrote: > A Dom, 25-09-2016 às 15:52 -0700, Junio C Hamano escreveu: >> > @@ -252,7 +253,7 @@ sub list_untracked { >> > } >> > >> > my $status_fmt = '%12s %12s %s'; >> > -my $status_head = sprintf($status_fmt, 'staged', 'unstaged', 'path'); >> > +my

Re: [PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-09-28 Thread Vasco Almeida
A Dom, 25-09-2016 às 15:52 -0700, Junio C Hamano escreveu: > > @@ -252,7 +253,7 @@ sub list_untracked { > >  } > >   > >  my $status_fmt = '%12s %12s %s'; > > -my $status_head = sprintf($status_fmt, 'staged', 'unstaged', 'path'); > > +my $status_head = sprintf($status_fmt, __('staged'), __('unstage

Re: [PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-09-25 Thread Junio C Hamano
Vasco Almeida writes: > Mark simple strings (without interpolation) for translation. > > Brackets around first parameter of ternary operator is necessary because > otherwise xgettext fails to extract strings marked for translation from > the rest of the file. > > Signed-off-by: Vasco Almeida > -

[PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-08-31 Thread Vasco Almeida
Mark simple strings (without interpolation) for translation. Brackets around first parameter of ternary operator is necessary because otherwise xgettext fails to extract strings marked for translation from the rest of the file. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 68 +++

[PATCH v2 01/11] i18n: add--interactive: mark strings for translation

2016-06-29 Thread Vasco Almeida
Mark simple strings (without interpolation) for translation. Brackets around first parameter of ternary operator is necessary because otherwise xgettext fails to extract strings marked for translation from the rest of the file. Signed-off-by: Vasco Almeida --- git-add--interactive.perl | 68 +++