[PATCH v2 02/44] ruby: add support for internal ruby programs

2013-09-28 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Makefile | 9 + ruby.c | 19 ++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2fdee15..27e61c0 100644 --- a/Makefile +++ b/Makefile @@ -429,6 +429,7 @@

Re: [PATCH v2 02/44] ruby: add support for internal ruby programs

2013-09-28 Thread Ramkumar Ramachandra
Felipe Contreras wrote: +$(RUBY_PROGRAMS): git-ruby$X + $(QUIET_BUILT_IN)$(RM) $@ \ + ln lt; $@ 2/dev/null || \ + ln -s lt; $@ 2/dev/null || \ + cp lt; $@ Why so many fallbacks? Will the hard-link (the first ln) ever fail? diff --git a/ruby.c b/ruby.c index

Re: [PATCH v2 02/44] ruby: add support for internal ruby programs

2013-09-28 Thread Felipe Contreras
On Sat, Sep 28, 2013 at 11:40 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Felipe Contreras wrote: +$(RUBY_PROGRAMS): git-ruby$X + $(QUIET_BUILT_IN)$(RM) $@ \ + ln lt; $@ 2/dev/null || \ + ln -s lt; $@ 2/dev/null || \ + cp lt; $@ Why so many fallbacks? Will

Re: [PATCH v2 02/44] ruby: add support for internal ruby programs

2013-09-28 Thread Felipe Contreras
On Sat, Sep 28, 2013 at 11:56 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Sep 28, 2013 at 11:40 PM, Ramkumar Ramachandra diff --git a/ruby.c b/ruby.c index ee6a0e7..339e376 100644 --- a/ruby.c +++ b/ruby.c @@ -52,5 +52,22 @@ static int run_ruby_command(const char *cmd,