Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()
On 01/15/2013 07:51 PM, Matt Kraai wrote: On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and parse_list. Yes, you're right. Thanks. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()
Michael Haggerty mhag...@alum.mit.edu writes: On 01/15/2013 07:51 PM, Matt Kraai wrote: On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and parse_list. Yes, you're right. Thanks. I think I've fixed this (and some other minor points in other patches in the series) while queuing; please check master..3691031c after fetching from me. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()
On 01/16/2013 04:34 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: On 01/15/2013 07:51 PM, Matt Kraai wrote: On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and parse_list. Yes, you're right. Thanks. I think I've fixed this (and some other minor points in other patches in the series) while queuing; please check master..3691031c after fetching from me. Looks good. Thanks. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()
The function is only called from here. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- imap-send.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/imap-send.c b/imap-send.c index f193211..cbbf845 100644 --- a/imap-send.c +++ b/imap-send.c @@ -669,21 +669,16 @@ bail: return -1; } -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) { struct imap_list *head; - if (!parse_imap_list_l(imap, sp, head, 0)) + if (!parse_imap_list_l(NULL, sp, head, 0)) return head; free_list(head); return NULL; } -static struct imap_list *parse_list(char **sp) -{ - return parse_imap_list(NULL, sp); -} - static void parse_capability(struct imap *imap, char *cmd) { char *arg; -- 1.8.0.3 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()
On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and parse_list. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html