Re: [PATCH v2 1/3] diff-highlight: add some tests.

2016-08-19 Thread Brian Henderson
On Fri, Aug 19, 2016 at 10:51:23AM -0400, Jeff King wrote: > On Fri, Aug 19, 2016 at 07:42:35AM -0700, Brian Henderson wrote: > > > > > +# PERL is required, but assumed to be present, although not > > > > necessarily modern > > > > +# some tests require 5.8 > > > > +test_expect_success PERL

Re: [PATCH v2 1/3] diff-highlight: add some tests.

2016-08-19 Thread Jeff King
On Fri, Aug 19, 2016 at 07:42:35AM -0700, Brian Henderson wrote: > > > +# PERL is required, but assumed to be present, although not necessarily > > > modern > > > +# some tests require 5.8 > > > +test_expect_success PERL 'name' 'true' > > > > If the platform lacks PERL prerequisite, this will

Re: [PATCH v2 1/3] diff-highlight: add some tests.

2016-08-19 Thread Brian Henderson
On Wed, Aug 17, 2016 at 12:09:25PM -0700, Junio C Hamano wrote: > Brian Henderson writes: > > > + > > +# PERL is required, but assumed to be present, although not necessarily > > modern > > +# some tests require 5.8 > > +test_expect_success PERL 'name' 'true' > > If

Re: [PATCH v2 1/3] diff-highlight: add some tests.

2016-08-17 Thread Junio C Hamano
Brian Henderson writes: > Signed-off-by: Brian Henderson > --- > contrib/diff-highlight/Makefile | 5 ++ > contrib/diff-highlight/t/Makefile| 22 > contrib/diff-highlight/t/t9400-diff-highlight.sh | 62

[PATCH v2 1/3] diff-highlight: add some tests.

2016-08-17 Thread Brian Henderson
Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 ++ contrib/diff-highlight/t/Makefile| 22 contrib/diff-highlight/t/t9400-diff-highlight.sh | 62 +