Re: [PATCH v2 12/12] pretty: support %>> that steal trailing spaces

2013-04-01 Thread Junio C Hamano
The last three patches are a lot of fun.  It would be nice to have
some test vectors for them.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 12/12] pretty: support %>> that steal trailing spaces

2013-03-30 Thread Nguyễn Thái Ngọc Duy
This is pretty useful in `%<(100)%s%Cred%>(20)% an' where %s does not
use up all 100 columns and %an needs more than 20 columns. By
replacing %>(20) with %>>(20), %an can steal spaces from %s.

%>> understands escape sequences, so %Cred does not stop it from
stealing spaces in %<(100).

Signed-off-by: Nguyễn Thái Ngọc Duy 
---
 Documentation/pretty-formats.txt |  5 -
 pretty.c | 34 ++
 utf8.c   |  2 +-
 utf8.h   |  1 +
 4 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
index f2df941..73ae4d6 100644
--- a/Documentation/pretty-formats.txt
+++ b/Documentation/pretty-formats.txt
@@ -170,7 +170,10 @@ The placeholders are:
   columns, padding spaces on the right if necessary
 - '%>()', '%>|()': similar to '%<()', '%<|()'
   respectively, but padding spaces on the left
-- '%><()', '%><|()': similar to '%<()', '%<|()'
+- '%>>()', '%>>|()': similar to '%>()', '%>|()'
+  respectively, except that if the next placeholder takes more spaces
+  than given and there are spaces on its left, use those spaces
+- '%><()', '%><|()': similar to '% <()', '%<|()'
   respectively, but padding both sides (i.e. the text is centered)
 
 NOTE: Some placeholders may depend on other options given to the
diff --git a/pretty.c b/pretty.c
index 29384b5..892274d 100644
--- a/pretty.c
+++ b/pretty.c
@@ -764,6 +764,7 @@ enum flush_type {
no_flush,
flush_right,
flush_left,
+   flush_left_and_steal,
flush_both
 };
 
@@ -1037,6 +1038,9 @@ static size_t parse_padding_placeholder(struct strbuf *sb,
if (*ch == '<') {
flush_type = flush_both;
ch++;
+   } else if (*ch == '>') {
+   flush_type = flush_left_and_steal;
+   ch++;
} else
flush_type = flush_left;
break;
@@ -1360,6 +1364,36 @@ static size_t format_and_pad_commit(struct strbuf *sb, 
/* in UTF-8 */
total_consumed++;
}
len = utf8_strnwidth(local_sb.buf, -1, 1);
+
+   if (c->flush_type == flush_left_and_steal) {
+   const char *ch = sb->buf + sb->len - 1;
+   while (len > padding && ch > sb->buf) {
+   const char *p;
+   if (*ch == ' ') {
+   ch--;
+   padding++;
+   continue;
+   }
+   /* check for trailing ansi sequences */
+   if (*ch != 'm')
+   break;
+   p = ch - 1;
+   while (ch - p < 10 && *p != '\033')
+   p--;
+   if (*p != '\033' ||
+   ch + 1 - p != display_mode_esc_sequence_len(p))
+   break;
+   /*
+* got a good ansi sequence, put it back to
+* local_sb as we're cutting sb
+*/
+   strbuf_insert(&local_sb, 0, p, ch + 1 - p);
+   ch = p - 1;
+   }
+   strbuf_setlen(sb, ch + 1 - sb->buf);
+   c->flush_type = flush_left;
+   }
+
if (len > padding) {
switch (c->truncate) {
case trunc_left:
diff --git a/utf8.c b/utf8.c
index 766df80..414ae49 100644
--- a/utf8.c
+++ b/utf8.c
@@ -9,7 +9,7 @@ struct interval {
   int last;
 };
 
-static size_t display_mode_esc_sequence_len(const char *s)
+size_t display_mode_esc_sequence_len(const char *s)
 {
const char *p = s;
if (*p++ != '\033')
diff --git a/utf8.h b/utf8.h
index faf2f91..e913edb 100644
--- a/utf8.h
+++ b/utf8.h
@@ -3,6 +3,7 @@
 
 typedef unsigned int ucs_char_t;  /* assuming 32bit int */
 
+size_t display_mode_esc_sequence_len(const char *s);
 int utf8_width(const char **start, size_t *remainder_p);
 int utf8_strnwidth(const char *string, int len, int skip_ansi);
 int utf8_strwidth(const char *string);
-- 
1.8.2.83.gc99314b

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html