Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-08 Thread Célestin Matte
Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? I assumed it was two distinct commits, but thinking about it, removing a library could have its

Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-08 Thread Matthieu Moy
Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct commits? That's the same. You write commits

Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-08 Thread Célestin Matte
Le 08/06/2013 20:41, Matthieu Moy a écrit : Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches (IMHO, though others may disagree). Two distinct patches or two distinct

Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-08 Thread Matthieu Moy
Célestin Matte celestin.ma...@ensimag.fr writes: Oh, I thought a part of a patch was called a commit. 1 patch = 1 commit 1 patch series = several commits sent together. Will normally end-up in a branch in Junio's repo (named with initials/topic) -- Matthieu Moy

Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-08 Thread Eric Sunshine
On Sat, Jun 8, 2013 at 2:45 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Le 08/06/2013 20:41, Matthieu Moy a écrit : Célestin Matte celestin.ma...@ensimag.fr writes: Le 08/06/2013 02:14, Eric Sunshine a écrit : These two changes are unrelated and could be split into distinct patches

[PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-07 Thread Célestin Matte
Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr --- contrib/mw-to-git/git-remote-mediawiki.perl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl

Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2

2013-06-07 Thread Eric Sunshine
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte celestin.ma...@ensimag.fr wrote: Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr Signed-off-by: Matthieu Moy matthieu@grenoble-inp.fr --- contrib/mw-to-git/git-remote-mediawiki.perl |4 ++-- 1 file changed, 2 insertions(+), 2