Re: [PATCH v2 14/27] update-ref.c: Extract a new function, parse_next_sha1()

On 03/24/2014 01:56 PM, Michael Haggerty wrote: > +/* > + * For backwards compatibility, accept an empty string for create's > + * in binary mode to be equivalent to specifying zeros. > + */ > +#define PARSE_SHA1_ALLOW_EMPTY 0x02 The comment should say "update's", not "create's". -Brad -- To un

[PATCH v2 14/27] update-ref.c: Extract a new function, parse_next_sha1()

Replace three functions, update_store_new_sha1(), update_store_old_sha1(), and parse_next_arg(), with a single function, parse_next_sha1(). The new function takes care of a whole argument, including checking whether it is there, converting it to an SHA-1, and emitting errors on EOF or for invalid