Re: [PATCH v2 2/3] Refactor parts of in_delta_base_cache/cache_or_unpack_entry

2013-03-26 Thread thomas
Junio C Hamano writes: > Thomas Rast writes: > >> The delta base cache lookup and test were shared. Refactor them; >> we'll need both parts again. Also, we'll use the clearing routine >> later. >> >> Signed-off-by: Thomas Rast >> --- > > Looks like a very straight-forward rewrite. > > The onl

Re: [PATCH v2 2/3] Refactor parts of in_delta_base_cache/cache_or_unpack_entry

2013-03-25 Thread Junio C Hamano
Thomas Rast writes: > The delta base cache lookup and test were shared. Refactor them; > we'll need both parts again. Also, we'll use the clearing routine > later. > > Signed-off-by: Thomas Rast > --- Looks like a very straight-forward rewrite. The only little concern I may have is this cmp_

[PATCH v2 2/3] Refactor parts of in_delta_base_cache/cache_or_unpack_entry

2013-03-25 Thread Thomas Rast
The delta base cache lookup and test were shared. Refactor them; we'll need both parts again. Also, we'll use the clearing routine later. Signed-off-by: Thomas Rast --- sha1_file.c | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) diff --git